Commit 1b3979b9 by Geoff Lang

Pass the gl::Texture object into Surface::bindTexImage.

BUG=540829 Change-Id: Iee602165e69bfe574821c6f628a745c32932a938 Reviewed-on: https://chromium-review.googlesource.com/316800Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Tested-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent 02bbec19
...@@ -185,7 +185,7 @@ Error Surface::bindTexImage(gl::Texture *texture, EGLint buffer) ...@@ -185,7 +185,7 @@ Error Surface::bindTexImage(gl::Texture *texture, EGLint buffer)
texture->bindTexImageFromSurface(this); texture->bindTexImageFromSurface(this);
mTexture.set(texture); mTexture.set(texture);
return mImplementation->bindTexImage(buffer); return mImplementation->bindTexImage(texture, buffer);
} }
Error Surface::releaseTexImage(EGLint buffer) Error Surface::releaseTexImage(EGLint buffer)
......
...@@ -31,7 +31,7 @@ class MockSurfaceImpl : public rx::SurfaceImpl ...@@ -31,7 +31,7 @@ class MockSurfaceImpl : public rx::SurfaceImpl
MOCK_METHOD0(swap, egl::Error()); MOCK_METHOD0(swap, egl::Error());
MOCK_METHOD4(postSubBuffer, egl::Error(EGLint, EGLint, EGLint, EGLint)); MOCK_METHOD4(postSubBuffer, egl::Error(EGLint, EGLint, EGLint, EGLint));
MOCK_METHOD2(querySurfacePointerANGLE, egl::Error(EGLint, void**)); MOCK_METHOD2(querySurfacePointerANGLE, egl::Error(EGLint, void**));
MOCK_METHOD1(bindTexImage, egl::Error(EGLint)); MOCK_METHOD2(bindTexImage, egl::Error(gl::Texture*, EGLint));
MOCK_METHOD1(releaseTexImage, egl::Error(EGLint)); MOCK_METHOD1(releaseTexImage, egl::Error(EGLint));
MOCK_METHOD1(setSwapInterval, void(EGLint)); MOCK_METHOD1(setSwapInterval, void(EGLint));
MOCK_CONST_METHOD0(getWidth, EGLint()); MOCK_CONST_METHOD0(getWidth, EGLint());
......
...@@ -36,7 +36,7 @@ class SurfaceImpl : public FramebufferAttachmentObjectImpl ...@@ -36,7 +36,7 @@ class SurfaceImpl : public FramebufferAttachmentObjectImpl
virtual egl::Error swap() = 0; virtual egl::Error swap() = 0;
virtual egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) = 0; virtual egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) = 0;
virtual egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) = 0; virtual egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) = 0;
virtual egl::Error bindTexImage(EGLint buffer) = 0; virtual egl::Error bindTexImage(gl::Texture *texture, EGLint buffer) = 0;
virtual egl::Error releaseTexImage(EGLint buffer) = 0; virtual egl::Error releaseTexImage(EGLint buffer) = 0;
virtual void setSwapInterval(EGLint interval) = 0; virtual void setSwapInterval(EGLint interval) = 0;
......
...@@ -91,7 +91,7 @@ FramebufferImpl *SurfaceD3D::createDefaultFramebuffer(const gl::Framebuffer::Dat ...@@ -91,7 +91,7 @@ FramebufferImpl *SurfaceD3D::createDefaultFramebuffer(const gl::Framebuffer::Dat
return mRenderer->createFramebuffer(data); return mRenderer->createFramebuffer(data);
} }
egl::Error SurfaceD3D::bindTexImage(EGLint) egl::Error SurfaceD3D::bindTexImage(gl::Texture *, EGLint)
{ {
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
} }
......
...@@ -38,7 +38,7 @@ class SurfaceD3D : public SurfaceImpl ...@@ -38,7 +38,7 @@ class SurfaceD3D : public SurfaceImpl
egl::Error swap() override; egl::Error swap() override;
egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override; egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override;
egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override; egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
egl::Error bindTexImage(EGLint buffer) override; egl::Error bindTexImage(gl::Texture *texture, EGLint buffer) override;
egl::Error releaseTexImage(EGLint buffer) override; egl::Error releaseTexImage(EGLint buffer) override;
void setSwapInterval(EGLint interval) override; void setSwapInterval(EGLint interval) override;
......
...@@ -34,7 +34,7 @@ class PbufferSurfaceCGL : public SurfaceGL ...@@ -34,7 +34,7 @@ class PbufferSurfaceCGL : public SurfaceGL
egl::Error swap() override; egl::Error swap() override;
egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override; egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override;
egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override; egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
egl::Error bindTexImage(EGLint buffer) override; egl::Error bindTexImage(gl::Texture *texture, EGLint buffer) override;
egl::Error releaseTexImage(EGLint buffer) override; egl::Error releaseTexImage(EGLint buffer) override;
void setSwapInterval(EGLint interval) override; void setSwapInterval(EGLint interval) override;
......
...@@ -95,7 +95,7 @@ egl::Error PbufferSurfaceCGL::querySurfacePointerANGLE(EGLint attribute, void ** ...@@ -95,7 +95,7 @@ egl::Error PbufferSurfaceCGL::querySurfacePointerANGLE(EGLint attribute, void **
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
} }
egl::Error PbufferSurfaceCGL::bindTexImage(EGLint buffer) egl::Error PbufferSurfaceCGL::bindTexImage(gl::Texture *texture, EGLint buffer)
{ {
UNIMPLEMENTED(); UNIMPLEMENTED();
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
......
...@@ -66,7 +66,7 @@ class WindowSurfaceCGL : public SurfaceGL ...@@ -66,7 +66,7 @@ class WindowSurfaceCGL : public SurfaceGL
egl::Error swap() override; egl::Error swap() override;
egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override; egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override;
egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override; egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
egl::Error bindTexImage(EGLint buffer) override; egl::Error bindTexImage(gl::Texture *texture, EGLint buffer) override;
egl::Error releaseTexImage(EGLint buffer) override; egl::Error releaseTexImage(EGLint buffer) override;
void setSwapInterval(EGLint interval) override; void setSwapInterval(EGLint interval) override;
......
...@@ -274,7 +274,7 @@ egl::Error WindowSurfaceCGL::querySurfacePointerANGLE(EGLint attribute, void **v ...@@ -274,7 +274,7 @@ egl::Error WindowSurfaceCGL::querySurfacePointerANGLE(EGLint attribute, void **v
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
} }
egl::Error WindowSurfaceCGL::bindTexImage(EGLint buffer) egl::Error WindowSurfaceCGL::bindTexImage(gl::Texture *texture, EGLint buffer)
{ {
UNIMPLEMENTED(); UNIMPLEMENTED();
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
......
...@@ -97,7 +97,7 @@ egl::Error PbufferSurfaceGLX::querySurfacePointerANGLE(EGLint attribute, void ** ...@@ -97,7 +97,7 @@ egl::Error PbufferSurfaceGLX::querySurfacePointerANGLE(EGLint attribute, void **
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
} }
egl::Error PbufferSurfaceGLX::bindTexImage(EGLint buffer) egl::Error PbufferSurfaceGLX::bindTexImage(gl::Texture *texture, EGLint buffer)
{ {
UNIMPLEMENTED(); UNIMPLEMENTED();
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
......
...@@ -36,7 +36,7 @@ class PbufferSurfaceGLX : public SurfaceGL ...@@ -36,7 +36,7 @@ class PbufferSurfaceGLX : public SurfaceGL
egl::Error swap() override; egl::Error swap() override;
egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override; egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override;
egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override; egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
egl::Error bindTexImage(EGLint buffer) override; egl::Error bindTexImage(gl::Texture *texture, EGLint buffer) override;
egl::Error releaseTexImage(EGLint buffer) override; egl::Error releaseTexImage(EGLint buffer) override;
void setSwapInterval(EGLint interval) override; void setSwapInterval(EGLint interval) override;
......
...@@ -166,7 +166,7 @@ egl::Error WindowSurfaceGLX::querySurfacePointerANGLE(EGLint attribute, void **v ...@@ -166,7 +166,7 @@ egl::Error WindowSurfaceGLX::querySurfacePointerANGLE(EGLint attribute, void **v
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
} }
egl::Error WindowSurfaceGLX::bindTexImage(EGLint buffer) egl::Error WindowSurfaceGLX::bindTexImage(gl::Texture *texture, EGLint buffer)
{ {
UNIMPLEMENTED(); UNIMPLEMENTED();
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
......
...@@ -37,7 +37,7 @@ class WindowSurfaceGLX : public SurfaceGL ...@@ -37,7 +37,7 @@ class WindowSurfaceGLX : public SurfaceGL
egl::Error swap() override; egl::Error swap() override;
egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override; egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override;
egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override; egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
egl::Error bindTexImage(EGLint buffer) override; egl::Error bindTexImage(gl::Texture *texture, EGLint buffer) override;
egl::Error releaseTexImage(EGLint buffer) override; egl::Error releaseTexImage(EGLint buffer) override;
void setSwapInterval(EGLint interval) override; void setSwapInterval(EGLint interval) override;
......
...@@ -146,7 +146,7 @@ static int GetWGLBufferBindTarget(EGLint buffer) ...@@ -146,7 +146,7 @@ static int GetWGLBufferBindTarget(EGLint buffer)
} }
} }
egl::Error PbufferSurfaceWGL::bindTexImage(EGLint buffer) egl::Error PbufferSurfaceWGL::bindTexImage(gl::Texture *texture, EGLint buffer)
{ {
if (!mFunctionsWGL->bindTexImageARB(mPbuffer, GetWGLBufferBindTarget(buffer))) if (!mFunctionsWGL->bindTexImageARB(mPbuffer, GetWGLBufferBindTarget(buffer)))
{ {
......
...@@ -39,7 +39,7 @@ class PbufferSurfaceWGL : public SurfaceGL ...@@ -39,7 +39,7 @@ class PbufferSurfaceWGL : public SurfaceGL
egl::Error swap() override; egl::Error swap() override;
egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override; egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override;
egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override; egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
egl::Error bindTexImage(EGLint buffer) override; egl::Error bindTexImage(gl::Texture *texture, EGLint buffer) override;
egl::Error releaseTexImage(EGLint buffer) override; egl::Error releaseTexImage(EGLint buffer) override;
void setSwapInterval(EGLint interval) override; void setSwapInterval(EGLint interval) override;
......
...@@ -119,7 +119,7 @@ egl::Error WindowSurfaceWGL::querySurfacePointerANGLE(EGLint attribute, void **v ...@@ -119,7 +119,7 @@ egl::Error WindowSurfaceWGL::querySurfacePointerANGLE(EGLint attribute, void **v
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
} }
egl::Error WindowSurfaceWGL::bindTexImage(EGLint buffer) egl::Error WindowSurfaceWGL::bindTexImage(gl::Texture *texture, EGLint buffer)
{ {
UNIMPLEMENTED(); UNIMPLEMENTED();
return egl::Error(EGL_SUCCESS); return egl::Error(EGL_SUCCESS);
......
...@@ -34,7 +34,7 @@ class WindowSurfaceWGL : public SurfaceGL ...@@ -34,7 +34,7 @@ class WindowSurfaceWGL : public SurfaceGL
egl::Error swap() override; egl::Error swap() override;
egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override; egl::Error postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height) override;
egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override; egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
egl::Error bindTexImage(EGLint buffer) override; egl::Error bindTexImage(gl::Texture *texture, EGLint buffer) override;
egl::Error releaseTexImage(EGLint buffer) override; egl::Error releaseTexImage(EGLint buffer) override;
void setSwapInterval(EGLint interval) override; void setSwapInterval(EGLint interval) override;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment