Vulkan: Handle new validation errors

src/libANGLE/renderer/vulkan/BufferVk.cpp

@@ -105,7 +105,7 @@ angle::Result BufferVk::setData(const gl::Context *context,
             VK_BUFFER_USAGE_VERTEX_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT |
             VK_BUFFER_USAGE_INDEX_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_SRC_BIT |
             VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT |
-            VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT;
+            VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_INDIRECT_BUFFER_BIT;
 
         VkBufferCreateInfo createInfo    = {};
         createInfo.sType                 = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;

src/libANGLE/renderer/vulkan/RendererVk.cpp

@@ -105,6 +105,8 @@ constexpr const char *kSkippedMessages[] = {
     "UNASSIGNED-CoreValidation-Shader-OutputNotConsumed",
     // http://anglebug.com/2796
     "UNASSIGNED-CoreValidation-Shader-PointSizeMissing",
+    // http://anglebug.com/3832
+    "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-00428",
 };
 
 // Suppress validation errors that are known

src/libANGLE/renderer/vulkan/vk_cache_utils.cpp

@@ -723,6 +723,15 @@ angle::Result GraphicsPipelineDesc::initializePipeline(
     inputAssemblyState.flags = 0;
     inputAssemblyState.topology =
         static_cast<VkPrimitiveTopology>(mInputAssemblyAndColorBlendStateInfo.primitive.topology);
+    // http://anglebug.com/3832
+    // We currently hit a VK Validation here where VUID
+    // VUID-VkPipelineInputAssemblyStateCreateInfo-topology-00428 is flagged because we allow
+    // primitiveRestartEnable to be true for topologies VK_PRIMITIVE_TOPOLOGY_POINT_LIST,
+    // VK_PRIMITIVE_TOPOLOGY_LINE_LIST, VK_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST
+    // VK_PRIMITIVE_TOPOLOGY_LINE_LIST_WITH_ADJACENCY,
+    // VK_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST_WITH_ADJACENCY and VK_PRIMITIVE_TOPOLOGY_PATCH_LIST
+    // However if we force primiteRestartEnable to FALSE we fail tests.
+    // Need to identify alternate fix.
     inputAssemblyState.primitiveRestartEnable =
         static_cast<VkBool32>(mInputAssemblyAndColorBlendStateInfo.primitive.restartEnable);