Commit 1da3cf63 by Shannon Woods

Removes sub-entry-point Framebuffer validations

BUG=angle:685 Change-Id: I2d630396a5971972f858cca9c39ceb6509492aa4 Reviewed-on: https://chromium-review.googlesource.com/205836Tested-by: 's avatarShannon Woods <shannonwoods@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent aa2ab7d8
...@@ -1515,25 +1515,19 @@ Texture *Context::getTargetTexture(GLenum target) const ...@@ -1515,25 +1515,19 @@ Texture *Context::getTargetTexture(GLenum target) const
GLuint Context::getTargetFramebufferHandle(GLenum target) const GLuint Context::getTargetFramebufferHandle(GLenum target) const
{ {
if (!ValidFramebufferTarget(target)) switch (target)
{
return GL_INVALID_INDEX;
}
if (target == GL_READ_FRAMEBUFFER_ANGLE)
{
return mState.readFramebuffer->id();
}
else
{ {
return mState.drawFramebuffer->id(); case GL_READ_FRAMEBUFFER_ANGLE: return mState.readFramebuffer->id();
case GL_DRAW_FRAMEBUFFER_ANGLE:
case GL_FRAMEBUFFER: return mState.drawFramebuffer->id();
default: UNREACHABLE(); return 0;
} }
} }
Framebuffer *Context::getTargetFramebuffer(GLenum target) const Framebuffer *Context::getTargetFramebuffer(GLenum target) const
{ {
GLuint framebufferHandle = getTargetFramebufferHandle(target); GLuint framebufferHandle = getTargetFramebufferHandle(target);
return (framebufferHandle == GL_INVALID_INDEX ? NULL : getFramebuffer(framebufferHandle)); return getFramebuffer(framebufferHandle);
} }
Texture2D *Context::getTexture2D() const Texture2D *Context::getTexture2D() const
......
...@@ -2603,7 +2603,6 @@ void __stdcall glGetFramebufferAttachmentParameteriv(GLenum target, GLenum attac ...@@ -2603,7 +2603,6 @@ void __stdcall glGetFramebufferAttachmentParameteriv(GLenum target, GLenum attac
} }
GLuint framebufferHandle = context->getTargetFramebufferHandle(target); GLuint framebufferHandle = context->getTargetFramebufferHandle(target);
ASSERT(framebufferHandle != GL_INVALID_INDEX);
gl::Framebuffer *framebuffer = context->getFramebuffer(framebufferHandle); gl::Framebuffer *framebuffer = context->getFramebuffer(framebufferHandle);
if (framebufferHandle == 0) if (framebufferHandle == 0)
......
...@@ -360,6 +360,11 @@ bool ValidateRenderbufferStorageParameters(const gl::Context *context, GLenum ta ...@@ -360,6 +360,11 @@ bool ValidateRenderbufferStorageParameters(const gl::Context *context, GLenum ta
bool ValidateFramebufferRenderbufferParameters(gl::Context *context, GLenum target, GLenum attachment, bool ValidateFramebufferRenderbufferParameters(gl::Context *context, GLenum target, GLenum attachment,
GLenum renderbuffertarget, GLuint renderbuffer) GLenum renderbuffertarget, GLuint renderbuffer)
{ {
if (!ValidFramebufferTarget(target))
{
return gl::error(GL_INVALID_ENUM, false);
}
gl::Framebuffer *framebuffer = context->getTargetFramebuffer(target); gl::Framebuffer *framebuffer = context->getTargetFramebuffer(target);
GLuint framebufferHandle = context->getTargetFramebufferHandle(target); GLuint framebufferHandle = context->getTargetFramebufferHandle(target);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment