Commit 1e064014 by Ben Wagner Committed by Commit Bot

Fix 'not all control paths return a value' and add to extra_warnings

Bug: angleproject:3356 Change-Id: I9831b2035bc1e887c6d5a68a444e69e2bf5aa60a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565055 Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 23667b7e
...@@ -120,6 +120,7 @@ config("extra_warnings") { ...@@ -120,6 +120,7 @@ config("extra_warnings") {
"/we4244", # Conversion: possible loss of data. "/we4244", # Conversion: possible loss of data.
"/we4456", # Variable shadowing. "/we4456", # Variable shadowing.
"/we4458", # declaration hides class member. "/we4458", # declaration hides class member.
"/we4715", # not all control paths return a value
"/we4800", # forcing value to bool. "/we4800", # forcing value to bool.
"/we4838", # narrowing conversion. "/we4838", # narrowing conversion.
] ]
......
...@@ -40,6 +40,9 @@ TextureType TextureTargetToType(TextureTarget target) ...@@ -40,6 +40,9 @@ TextureType TextureTargetToType(TextureTarget target)
return TextureType::_3D; return TextureType::_3D;
case TextureTarget::InvalidEnum: case TextureTarget::InvalidEnum:
return TextureType::InvalidEnum; return TextureType::InvalidEnum;
default:
UNREACHABLE();
return TextureType::InvalidEnum;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment