Vulkan: Fix TRex performance regression

TRex invalidates depth but doesn't disable depth before the render pass ends. The render pass isn't ended, but a storeOp of STORE was used instead of DONT_CARE, which causes a performance regression. Bug: b/163854287 Change-Id: Iebd9999ef66c11ff334db3eef2943f58eb2d5053 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377105Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>

Vulkan: Fix TRex performance regression
1ea22c31 · Ian Elliott · Commit Bot · 143193d5 · 1ea22c31
Commit 1ea22c31 authored Aug 25, 2020 by Ian Elliott Committed by Commit Bot Aug 26, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

vk_helpers.cpp src/libANGLE/renderer/vulkan/vk_helpers.cpp +2 -2

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_helpers.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_helpers.cpp
@@ -865,12 +865,12 @@ void CommandBufferHelper::endRenderPass(ContextVk *contextVk)
    PackedAttachmentOpsDesc &dsOps = mAttachmentOps[mDepthStencilAttachmentIndex];

    // Address invalidated depth/stencil attachments
-    if (mDepthInvalidatedState == Invalidated && !mDepthEnabled)
+    if (mDepthInvalidatedState == Invalidated)
    {
        // The depth attachment is invalid, so don't store it
        dsOps.storeOp = VK_ATTACHMENT_STORE_OP_DONT_CARE;
    }
-    if (mStencilInvalidatedState == Invalidated && !mStencilEnabled)
+    if (mStencilInvalidatedState == Invalidated)
    {
        // The stencil attachment is invalid, so don't store it
        dsOps.stencilStoreOp = VK_ATTACHMENT_STORE_OP_DONT_CARE;