Re-enable crash testing in angle_unittests.

This is an experimental test to see if this works now. Disabled on Win/ASAN because of conflicts with the crash callback. Bug: angleproject:5239 Change-Id: I280b18ab8846de79b561f26716df9ba374cfd9a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496040Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Re-enable crash testing in angle_unittests.
21add124 · Jamie Madill · Commit Bot · d6d07359 · 21add124
Commit 21add124 authored Oct 25, 2020 by Jamie Madill Committed by Commit Bot Oct 26, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 5 deletions

TestSuite_unittest.cpp src/tests/test_utils/runner/TestSuite_unittest.cpp +11 -5

No files found.
--- a/src/tests/test_utils/runner/TestSuite_unittest.cpp
+++ b/src/tests/test_utils/runner/TestSuite_unittest.cpp
@@ -83,7 +83,10 @@ TEST_F(TestSuiteTest, RunMockTests)
        {{"MockTestSuiteTest", "DISABLED_Pass"}, {TestResultType::Pass, 0.0}},
        {{"MockTestSuiteTest", "DISABLED_Fail"}, {TestResultType::Fail, 0.0}},
        {{"MockTestSuiteTest", "DISABLED_Timeout"}, {TestResultType::Timeout, 0.0}},
-        // {{"MockTestSuiteTest", "DISABLED_Crash"}, {TestResultType::Crash, 0.0}},
+    // Issues with ASAN on Windows. http://anglebug.com/5238
+#if !defined(ANGLE_PLATFORM_WINDOWS) || !defined(ANGLE_WITH_ASAN)
+        {{"MockTestSuiteTest", "DISABLED_Crash"}, {TestResultType::Crash, 0.0}},
+#endif  // !defined(ANGLE_PLATFORM_WINDOWS) || !defined(ANGLE_WITH_ASAN)
    };
    EXPECT_EQ(expectedResults, actual.results);
@@ -107,9 +110,12 @@ TEST(MockTestSuiteTest, DISABLED_Timeout)
    angle::Sleep(20000);
 }
+// Issues with ASAN on Windows. http://anglebug.com/5238
+#if !defined(ANGLE_PLATFORM_WINDOWS) || !defined(ANGLE_WITH_ASAN)
 // Trigger a test crash.
-// TEST(MockTestSuiteTest, DISABLED_Crash)
+TEST(MockTestSuiteTest, DISABLED_Crash)
-// {
+{
-//     ANGLE_CRASH();
+    ANGLE_CRASH();
-// }
+}
+#endif  // !defined(ANGLE_PLATFORM_WINDOWS) || !defined(ANGLE_WITH_ASAN)
 }  // namespace