Fix string literal comparison in validation

String literals shouldn't be compared by pointer, especially if the literal is declared in a header (so the two pointers can come from different translation units, because the string literal might have a different copy in each). Use strcmp instead. Bug: angleproject:4175 Change-Id: I6002ccb185f48928b67ce8a7b3508e427761a8c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940568 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Fix string literal comparison in validation
232d009d · Shahbaz Youssefi · Commit Bot · 33adad19 · 232d009d
Commit 232d009d authored Nov 27, 2019 by Shahbaz Youssefi Committed by Commit Bot Nov 27, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

validationES.h src/libANGLE/validationES.h +2 -2

No files found.
--- a/src/libANGLE/validationES.h
+++ b/src/libANGLE/validationES.h
@@ -324,9 +324,9 @@ ANGLE_INLINE bool ValidateDrawBase(Context *context, PrimitiveMode mode)

        // All errors from ValidateDrawStates should return INVALID_OPERATION except Framebuffer
        // Incomplete.
+        bool isFramebufferIncomplete = strcmp(errorMessage, err::kDrawFramebufferIncomplete) == 0;
        GLenum errorCode =
-            (errorMessage == err::kDrawFramebufferIncomplete ? GL_INVALID_FRAMEBUFFER_OPERATION
-                                                             : GL_INVALID_OPERATION);
+            isFramebufferIncomplete ? GL_INVALID_FRAMEBUFFER_OPERATION : GL_INVALID_OPERATION;
        context->validationError(errorCode, errorMessage);
        return false;
    }