GL: Temporarily disable GPU copy paths for rectangle texture sources.

Sampling from rectangle textures produces incorrect results for glCopyTextureCHROMIUM. Temporarily disable this path while the underlying issues are investigated. BUG=990368 Change-Id: I690252ed4d09cdb6a7fd94f6f24d1300c53afc1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1832496Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

GL: Temporarily disable GPU copy paths for rectangle texture sources.
24e7ecfc · Geoff Lang · 7dd03446 · 24e7ecfc
Commit 24e7ecfc authored Oct 01, 2019 by Geoff Lang
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

TextureGL.cpp src/libANGLE/renderer/gl/TextureGL.cpp +4 -1

No files found.
--- a/src/libANGLE/renderer/gl/TextureGL.cpp
+++ b/src/libANGLE/renderer/gl/TextureGL.cpp
@@ -893,7 +893,10 @@ angle::Result TextureGL::copySubTextureHelper(const gl::Context *context,
    // Behavior for now is to fallback to CPU readback implementation if the destination texture
    // is a luminance format. The correct solution is to handle both source and destination in the
    // luma workaround.
-    if (!destSRGB && !destLevelInfo.lumaWorkaround.enabled &&
+    // Temporarily disable GPU copies from rectangle textures until sampling issues are resolved in
+    // http://crbug.com/990368
+    if (!destSRGB && source->getType() != gl::TextureType::Rectangle &&
+        !destLevelInfo.lumaWorkaround.enabled &&
        nativegl::SupportsNativeRendering(functions, getType(), destLevelInfo.nativeInternalFormat))
    {
        bool copySucceeded = false;