Vulkan: Add IMAGE_USE_STORAGE bit only if necessary.

The VK_IMAGE_USAGE_STORAGE_BIT has negative performance impact. Right now we needed for overlay widgets. This CL will only add the bit if we actually have widget enabled. Bug: b/157774833 Change-Id: I3027df886c9b34ccfd667152fa4fb090dfadb45b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2225810Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>

Vulkan: Add IMAGE_USE_STORAGE bit only if necessary.
2611f98b · Charlie Lao · Commit Bot · 1df70f03 · 2611f98b
Commit 2611f98b authored Jun 02, 2020 by Charlie Lao Committed by Commit Bot Jun 02, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

SurfaceVk.cpp src/libANGLE/renderer/vulkan/SurfaceVk.cpp +2 -0

No files found.
--- a/src/libANGLE/renderer/vulkan/SurfaceVk.cpp
+++ b/src/libANGLE/renderer/vulkan/SurfaceVk.cpp
@@ -864,6 +864,7 @@ angle::Result WindowSurfaceVk::createSwapChain(vk::Context *context,
    // We need transfer src for reading back from the backbuffer.
    VkImageUsageFlags imageUsageFlags = kSurfaceVKColorImageUsageFlags;
+#if ANGLE_ENABLE_OVERLAY
    // We need storage image for compute writes (debug overlay output).
    VkFormatFeatureFlags featureBits =
        renderer->getImageFormatFeatureBits(nativeFormat, VK_FORMAT_FEATURE_STORAGE_IMAGE_BIT);
@@ -871,6 +872,7 @@ angle::Result WindowSurfaceVk::createSwapChain(vk::Context *context,
    {
        imageUsageFlags |= VK_IMAGE_USAGE_STORAGE_BIT;
    }
+#endif
    VkSwapchainCreateInfoKHR swapchainInfo = {};
    swapchainInfo.sType                    = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR;