infra: Set MSVC builders to compile-only.

We want to preserve the current test set without accidentally enabling new testinig paths with infra changes. Current MSVC is supported as compile-only. Bug: angleproject:5114 Change-Id: Iffc4ac3f7dc3845e5d767fdcdbfa9d5fac27f371 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848646Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

infra: Set MSVC builders to compile-only.
2a403f91 · Jamie Madill · Commit Bot · 7caff9d8 · 2a403f91 · 2a403f91
Commit 2a403f91 authored Apr 23, 2021 by Jamie Madill Committed by Commit Bot Apr 23, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 7 deletions

cr-buildbucket.cfg infra/config/generated/cr-buildbucket.cfg +6 -6

main.star infra/config/main.star +1 -1

No files found.
--- a/infra/config/generated/cr-buildbucket.cfg
+++ b/infra/config/generated/cr-buildbucket.cfg
@@ -246,7 +246,7 @@ buckets {
        cipd_version: "refs/heads/master"
        cmd: "recipes"
      }
-      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_and_test\",\"toolchain\":\"msvc\"}"
+      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_only\",\"toolchain\":\"msvc\"}"
      build_numbers: YES
      service_account: "angle-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
    }
@@ -274,7 +274,7 @@ buckets {
        cipd_version: "refs/heads/master"
        cmd: "recipes"
      }
-      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_and_test\",\"toolchain\":\"msvc\"}"
+      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_only\",\"toolchain\":\"msvc\"}"
      build_numbers: YES
      service_account: "angle-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
    }
@@ -316,7 +316,7 @@ buckets {
        cipd_version: "refs/heads/master"
        cmd: "recipes"
      }
-      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_and_test\",\"toolchain\":\"msvc\"}"
+      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_only\",\"toolchain\":\"msvc\"}"
      build_numbers: YES
      service_account: "angle-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
    }
@@ -577,7 +577,7 @@ buckets {
        cipd_version: "refs/heads/master"
        cmd: "recipes"
      }
-      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_and_test\",\"toolchain\":\"msvc\"}"
+      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_only\",\"toolchain\":\"msvc\"}"
      build_numbers: YES
      service_account: "angle-try-builder@chops-service-accounts.iam.gserviceaccount.com"
    }
@@ -605,7 +605,7 @@ buckets {
        cipd_version: "refs/heads/master"
        cmd: "recipes"
      }
-      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_and_test\",\"toolchain\":\"msvc\"}"
+      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_only\",\"toolchain\":\"msvc\"}"
      build_numbers: YES
      service_account: "angle-try-builder@chops-service-accounts.iam.gserviceaccount.com"
    }
@@ -647,7 +647,7 @@ buckets {
        cipd_version: "refs/heads/master"
        cmd: "recipes"
      }
-      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_and_test\",\"toolchain\":\"msvc\"}"
+      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"},\"builder_group\":\"angle\",\"platform\":\"win\",\"recipe\":\"angle\",\"test_mode\":\"compile_only\",\"toolchain\":\"msvc\"}"
      build_numbers: YES
      service_account: "angle-try-builder@chops-service-accounts.iam.gserviceaccount.com"
    }

--- a/infra/config/main.star
+++ b/infra/config/main.star
@@ -143,7 +143,7 @@ def angle_standalone_builder(name, debug, cpu, toolchain = "clang", uwp = False,
        properties["test_mode"] = "trace_tests"
    elif toolchain == "gcc":
        properties["test_mode"] = "checkout_only"
-    elif debug:
+    elif debug or toolchain == "msvc":
        properties["test_mode"] = "compile_only"
    else:
        properties["test_mode"] = "compile_and_test"