Skip to content

A
angle
Commit 2a895637 by Jamie Madill Committed by Shannon Woods
Options

Fix PBO missing unmap in some edge cases.

We had missed a few unmap calls in NativeBuffer11::copyFromStoage. This method is only called when PBOs are used in conjunction with SubData updates or when drawing with PBOs. BUG=angle:667 Change-Id: I04a2b78e830edb9439e25661a2676af374df439e Reviewed-on: https://chromium-review.googlesource.com/222920Tested-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarBrandon Jones <bajones@chromium.org> Reviewed-by: 's avatarShannon Woods <shannonwoods@chromium.org>
parent 964df49d
Showing with 3 additions and 0 deletions
src/libGLESv2/renderer/d3d/d3d11/Buffer11.cpp
...@@ -667,6 +667,9 @@ bool Buffer11::NativeBuffer11::copyFromStorage(BufferStorage11 *source, size_t s ...@@ -667,6 +667,9 @@ bool Buffer11::NativeBuffer11::copyFromStorage(BufferStorage11 *source, size_t s
// Offset bounds are validated at the API layer // Offset bounds are validated at the API layer
ASSERT(sourceOffset + size <= destOffset + mBufferSize); ASSERT(sourceOffset + size <= destOffset + mBufferSize);
memcpy(destPointer, sourcePointer, size); memcpy(destPointer, sourcePointer, size);
context->Unmap(mNativeBuffer, 0);
source->unmap();
} }
else else
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment