Commit 2e2fcfb5 by Manh Nguyen Committed by Commit Bot

Implement param capture for glGetUniform calls and extensions

Implement glGetUniform calls to fix crashes in UniformTest test group. Tests: UniformTest test group Bug: angleproject:4817 Change-Id: I132c61e053665b0642667aad51f1f3220d101d14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339542 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent a0880831
...@@ -548,7 +548,8 @@ void CaptureGetUniformfv_params(const State &glState, ...@@ -548,7 +548,8 @@ void CaptureGetUniformfv_params(const State &glState,
GLfloat *params, GLfloat *params,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); // the value returned cannot have size larger than a mat4 of floats
paramCapture->readBufferSizeBytes = 64;
} }
void CaptureGetUniformiv_params(const State &glState, void CaptureGetUniformiv_params(const State &glState,
...@@ -558,7 +559,8 @@ void CaptureGetUniformiv_params(const State &glState, ...@@ -558,7 +559,8 @@ void CaptureGetUniformiv_params(const State &glState,
GLint *params, GLint *params,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); // the value returned cannot have size larger than a mat4 of ints
paramCapture->readBufferSizeBytes = 64;
} }
void CaptureGetVertexAttribPointerv_pointer(const State &glState, void CaptureGetVertexAttribPointerv_pointer(const State &glState,
......
...@@ -2464,7 +2464,7 @@ void CaptureGetnUniformfvEXT_params(const State &glState, ...@@ -2464,7 +2464,7 @@ void CaptureGetnUniformfvEXT_params(const State &glState,
GLfloat *params, GLfloat *params,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); paramCapture->readBufferSizeBytes = bufSize;
} }
void CaptureGetnUniformivEXT_params(const State &glState, void CaptureGetnUniformivEXT_params(const State &glState,
...@@ -2475,7 +2475,7 @@ void CaptureGetnUniformivEXT_params(const State &glState, ...@@ -2475,7 +2475,7 @@ void CaptureGetnUniformivEXT_params(const State &glState,
GLint *params, GLint *params,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); paramCapture->readBufferSizeBytes = bufSize;
} }
void CaptureReadnPixelsEXT_data(const State &glState, void CaptureReadnPixelsEXT_data(const State &glState,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment