Skip to content

A
angle
Commit 2f5469c2 by Brett Wilson Committed by Jamie Madill
Options

Export include directories to dependents in GN.

Translator headers that are included by dependent code (example: ShaderLang.h) expect to be able to include files from "includes" (example: "KHR/khrplatform.h"). This automatically applies this include path to dependent targets. Change-Id: I6990f66132562f142a6cdf8b8c434d2dbaad1c98 Reviewed-on: https://chromium-review.googlesource.com/209452Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Tested-by: 's avatarBrett Wilson <brettw@chromium.org> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent 493daf5a
Showing with 11 additions and 0 deletions
BUILD.gn
...@@ -23,6 +23,14 @@ compiler_gypi = exec_script( ...@@ -23,6 +23,14 @@ compiler_gypi = exec_script(
"scope", "scope",
[ "src/compiler.gypi" ]) [ "src/compiler.gypi" ])
# This config is exported to dependent targets (and also applied to internal
# ones).
config("external_config") {
include_dirs = [
"include",
]
}
# This config is applied to internal Angle targets (not pushed to dependents). # This config is applied to internal Angle targets (not pushed to dependents).
config("internal_config") { config("internal_config") {
include_dirs = [ include_dirs = [
...@@ -47,6 +55,7 @@ component("translator") { ...@@ -47,6 +55,7 @@ component("translator") {
deps = [ deps = [
":translator_lib", ":translator_lib",
] ]
forward_dependent_configs_from = [ ":translator_lib" ]
} }
# Holds the shared includes so we only need to list them once. # Holds the shared includes so we only need to list them once.
...@@ -84,6 +93,7 @@ static_library("translator_lib") { ...@@ -84,6 +93,7 @@ static_library("translator_lib") {
":internal_config", ":internal_config",
"//build/config/compiler:no_chromium_code", "//build/config/compiler:no_chromium_code",
] ]
direct_dependent_configs = [ ":external_config" ]
deps = [ deps = [
":includes", ":includes",
...@@ -110,6 +120,7 @@ static_library("translator_static") { ...@@ -110,6 +120,7 @@ static_library("translator_static") {
deps = [ deps = [
":translator_lib", ":translator_lib",
] ]
forward_dependent_configs_from = [ ":translator_lib" ]
} }
config("commit_id_config") { config("commit_id_config") {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment