Vulkan: Fix missing visibility barrier for glReadPixels

glReadPixels uses a temporary buffer for readback and was missing an onBufferTransferWrite() call. Bug: angleproject:5669 Change-Id: I3c6daba176e332711fa1ab51e279526717486dd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717005Reviewed-by: Jie A Chen <jie.a.chen@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Vulkan: Fix missing visibility barrier for glReadPixels
3013f27c · Shahbaz Youssefi · Commit Bot · 4a24786e · 3013f27c
Commit 3013f27c authored Feb 23, 2021 by Shahbaz Youssefi Committed by Commit Bot Feb 24, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

vk_helpers.cpp src/libANGLE/renderer/vulkan/vk_helpers.cpp +8 -2

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_helpers.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_helpers.cpp
@@ -6401,8 +6401,14 @@ angle::Result ImageHelper::readPixels(ContextVk *contextVk,
    region.imageOffset       = srcOffset;
    region.imageSubresource  = srcSubresource;
-    commandBuffer->copyImageToBuffer(src->getImage(), src->getCurrentLayout(), bufferHandle, 1,
+    CommandBufferAccess readbackAccess;
-                                     &region);
+    readbackAccess.onBufferTransferWrite(stagingBuffer->getCurrentBuffer());
+    CommandBuffer *readbackCommandBuffer;
+    ANGLE_TRY(contextVk->getOutsideRenderPassCommandBuffer(readbackAccess, &readbackCommandBuffer));
+    readbackCommandBuffer->copyImageToBuffer(src->getImage(), src->getCurrentLayout(), bufferHandle,
+                                             1, &region);
    ANGLE_PERF_WARNING(contextVk->getDebug(), GL_DEBUG_SEVERITY_HIGH,
                       "GPU stall due to ReadPixels");