Skip to content

A
angle
Commit 31c9d16e by Austin Kinross Committed by Geoff Lang
Options

Re-land "Disable RTTI in VS release builds"

- Re-land with fix for Chromium Debug Windows builds Chrome forbids RTTI, but standalone ANGLE currently allows it. Disallowing RTTI in standalone release builds brings ANGLE and Chrome closer, and prevents accidental use of dynamic_cast in ANGLE. It also reduces binary size. Win10 libGLESv2 (x86) is 47KB smaller after this. BUG=angleproject:1239 Change-Id: I505fd0d72868a38444e47198a9bf85ee3e25719f Reviewed-on: https://chromium-review.googlesource.com/316830 Tryjob-Request: Austin Kinross <aukinros@microsoft.com> Tested-by: 's avatarAustin Kinross <aukinros@microsoft.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent 08bf81d5
Showing with 25 additions and 3 deletions
build/common.gypi
......@@ -99,7 +99,6 @@
'ExceptionHandling': '0',
'EnableFunctionLevelLinking': 'true',
'MinimalRebuild': 'false',
'RuntimeTypeInfo': 'true',
'WarningLevel': '4',
},
'VCLinkerTool':
......@@ -142,6 +141,7 @@
{
'Optimization': '0', # /Od
'BasicRuntimeChecks': '3',
'RuntimeTypeInfo': 'true',
'conditions':
[
['angle_build_winrt==1',
......@@ -200,6 +200,7 @@
'VCCLCompilerTool':
{
'Optimization': '2', # /Os
'RuntimeTypeInfo': 'false',
'conditions':
[
['angle_build_winrt==1',
......
src/tests/deqp.gypi
......@@ -1184,9 +1184,8 @@
{
'VCCLCompilerTool':
{
# dEQP requires exceptions and RTTI
# dEQP requires exceptions
'ExceptionHandling': 1,
'RuntimeTypeInfo': 'true',
},
'VCLinkerTool':
{
......@@ -1216,6 +1215,28 @@
},
},
},
'Debug_Base':
{
'msvs_settings':
{
'VCCLCompilerTool':
{
'RuntimeTypeInfo': 'true', # dEQP needs RTTI
},
},
},
'Release_Base':
{
'msvs_settings':
{
'VCCLCompilerTool':
{
'RuntimeTypeInfo': 'true', # dEQP needs RTTI
},
},
},
},
# Re-enable RTTI and exceptions, dEQP needs them.
'cflags_cc!':
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment