Vulkan:Skip appendToStartedRenderPass()

In the case where command graph is disabled, we don't need to call appendToStartedRenderPass(). Bug: angleproject:4029 Change-Id: I9b9d1ad666a903fcb63ab394944cfe7adb836a08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065708Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>

Vulkan:Skip appendToStartedRenderPass()
32101999 · Tobin Ehlis · Commit Bot · bb654cf8 · 32101999
Commit 32101999 authored Feb 19, 2020 by Tobin Ehlis Committed by Commit Bot Feb 20, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

UtilsVk.cpp src/libANGLE/renderer/vulkan/UtilsVk.cpp +4 -2

No files found.
--- a/src/libANGLE/renderer/vulkan/UtilsVk.cpp
+++ b/src/libANGLE/renderer/vulkan/UtilsVk.cpp
@@ -1279,7 +1279,8 @@ angle::Result UtilsVk::clearFramebuffer(ContextVk *contextVk,
    const gl::Rectangle &scissoredRenderArea = params.clearArea;

    vk::CommandBuffer *commandBuffer;
-    if (!framebuffer->appendToStartedRenderPass(&contextVk->getResourceUseList(),
+    if (!contextVk->commandGraphEnabled() ||
+        !framebuffer->appendToStartedRenderPass(&contextVk->getResourceUseList(),
                                                scissoredRenderArea, &commandBuffer))
    {
        ANGLE_TRY(framebuffer->startNewRenderPass(contextVk, scissoredRenderArea, &commandBuffer));
@@ -1516,7 +1517,8 @@ angle::Result UtilsVk::blitResolveImpl(ContextVk *contextVk,
    }

    vk::CommandBuffer *commandBuffer;
-    if (!framebuffer->appendToStartedRenderPass(&contextVk->getResourceUseList(), params.blitArea,
+    if (!contextVk->commandGraphEnabled() ||
+        !framebuffer->appendToStartedRenderPass(&contextVk->getResourceUseList(), params.blitArea,
                                                &commandBuffer))
    {
        ANGLE_TRY(framebuffer->startNewRenderPass(contextVk, params.blitArea, &commandBuffer));