Commit 322cc825 by Jamie Madill Committed by Commit Bot

Rename RenderPass test to performance counter test.

This is a better naming for new tests that will check other counters such as the number of command buffers, barriers, and descriptor set writes. Bug: angleproject:4911 Change-Id: I8b2c12f6e043c2833e64fa9627f781e61f8f0f3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2334089Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 382e698d
...@@ -20,6 +20,6 @@ angle_white_box_tests_win_sources = [ ...@@ -20,6 +20,6 @@ angle_white_box_tests_win_sources = [
angle_white_box_tests_vulkan_sources = [ angle_white_box_tests_vulkan_sources = [
"gl_tests/VulkanFormatTablesTest.cpp", "gl_tests/VulkanFormatTablesTest.cpp",
"gl_tests/VulkanFramebufferTest.cpp", "gl_tests/VulkanFramebufferTest.cpp",
"gl_tests/VulkanRenderPassCountTest.cpp", "gl_tests/VulkanPerformanceCounterTest.cpp",
"gl_tests/VulkanUniformUpdatesTest.cpp", "gl_tests/VulkanUniformUpdatesTest.cpp",
] ]
...@@ -3,8 +3,11 @@ ...@@ -3,8 +3,11 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// //
// VulkanRenderPassCountTest: // VulkanPerformanceCounterTest:
// Validates that specific GL calls don't break RenderPasses. // Validates specific GL call patterns with ANGLE performance counters.
// For example we can verify a certain call set doesn't break the RenderPass.
//
// TODO(jmadill): Move to a GL extension. http://anglebug.com/4918
#include "test_utils/ANGLETest.h" #include "test_utils/ANGLETest.h"
#include "test_utils/angle_test_instantiate.h" #include "test_utils/angle_test_instantiate.h"
...@@ -22,7 +25,7 @@ using namespace angle; ...@@ -22,7 +25,7 @@ using namespace angle;
namespace namespace
{ {
class VulkanRenderPassCountTest : public ANGLETest class VulkanPerformanceCounterTest : public ANGLETest
{ {
protected: protected:
rx::ContextVk *hackANGLE() const rx::ContextVk *hackANGLE() const
...@@ -34,7 +37,7 @@ class VulkanRenderPassCountTest : public ANGLETest ...@@ -34,7 +37,7 @@ class VulkanRenderPassCountTest : public ANGLETest
}; };
// Tests that texture updates to unused textures don't break the RP. // Tests that texture updates to unused textures don't break the RP.
TEST_P(VulkanRenderPassCountTest, NewTextureDoesNotBreakRenderPass) TEST_P(VulkanPerformanceCounterTest, NewTextureDoesNotBreakRenderPass)
{ {
// TODO(jmadill): Fix test. http://anglebug.com/4911 // TODO(jmadill): Fix test. http://anglebug.com/4911
ANGLE_SKIP_TEST_IF(IsVulkan()); ANGLE_SKIP_TEST_IF(IsVulkan());
...@@ -85,6 +88,6 @@ TEST_P(VulkanRenderPassCountTest, NewTextureDoesNotBreakRenderPass) ...@@ -85,6 +88,6 @@ TEST_P(VulkanRenderPassCountTest, NewTextureDoesNotBreakRenderPass)
EXPECT_EQ(expectedRenderPassCount, actualRenderPassCount); EXPECT_EQ(expectedRenderPassCount, actualRenderPassCount);
} }
ANGLE_INSTANTIATE_TEST(VulkanRenderPassCountTest, ES2_VULKAN(), ES3_VULKAN()); ANGLE_INSTANTIATE_TEST(VulkanPerformanceCounterTest, ES2_VULKAN(), ES3_VULKAN());
} // anonymous namespace } // anonymous namespace
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment