Vulkan: Prefer host cached memory for Buffers

This improves perf because vertex data upload uses host visible memory, and uncached memory can be slow. Test: Android on Windows with 1080Ti: glmark2 [build] vbo=false 265 -> 3900 fps Bug: angleproject:5515 Change-Id: Ib75582bbdb4ca4a22d3a121c7b477a23a8a809ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615742 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>

Vulkan: Prefer host cached memory for Buffers
326f128b · Lingfeng Yang · Commit Bot · 9325fd8b · 326f128b
Commit 326f128b authored Jan 07, 2021 by Lingfeng Yang Committed by Commit Bot Jan 11, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

vk_helpers.cpp src/libANGLE/renderer/vulkan/vk_helpers.cpp +8 -2

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_helpers.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_helpers.cpp
@@ -3139,10 +3139,16 @@ angle::Result BufferHelper::init(ContextVk *contextVk,
        createInfo = &modifiedCreateInfo;
    }

-    VkMemoryPropertyFlags requiredFlags =
-        (memoryPropertyFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
+    const VkMemoryPropertyFlags requiredFlags =
+        memoryPropertyFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
    VkMemoryPropertyFlags preferredFlags =
        (memoryPropertyFlags & (~VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT));
+    // If we want host visible memory, also ask for cached.  This can make a big difference for data
+    // upload.
+    if (requiredFlags != 0)
+    {
+        preferredFlags |= VK_MEMORY_PROPERTY_HOST_CACHED_BIT;
+    }

    const Allocator &allocator = renderer->getAllocator();
    bool persistentlyMapped    = renderer->getFeatures().persistentlyMappedBuffers.enabled;