Enable MSVC warning 4312.

This is caught in the Skia build. Bug: skia:7647 Change-Id: I9b164f6fcc55b7e13981659ee8a08766a99a2122 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381084 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>

Enable MSVC warning 4312.
330c8673 · Jamie Madill · Commit Bot · 966a62cb · 330c8673 · 330c8673
Commit 330c8673 authored Aug 28, 2020 by Jamie Madill Committed by Commit Bot Aug 28, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

BUILD.gn BUILD.gn +1 -0

FrameCapture.cpp src/libANGLE/FrameCapture.cpp +2 -2

No files found.
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -133,6 +133,7 @@ config("extra_warnings") {
  if (is_win) {
    cflags += [
      "/we4244",  # Conversion: possible loss of data.
+      "/we4312",  # Conversion: greater size.
      "/we4456",  # Variable shadowing.
      "/we4458",  # declaration hides class member.
      "/we4715",  # not all control paths return a value

--- a/src/libANGLE/FrameCapture.cpp
+++ b/src/libANGLE/FrameCapture.cpp
@@ -2957,8 +2957,8 @@ void CaptureMidExecutionSetup(const gl::Context *context,
    const gl::SyncManager &syncs = apiState.getSyncManagerForCapture();
    for (const auto &syncIter : syncs)
    {
-        GLsync syncID  = reinterpret_cast<GLsync>(syncIter.first);
-        gl::Sync *sync = syncIter.second;
+        GLsync syncID        = gl::bitCast<GLsync>(syncIter.first);
+        const gl::Sync *sync = syncIter.second;

        if (!sync)
        {