Commit 33e72d99 by Oystein Eftevaag Committed by Commit Bot

Removed an assert about addTraceEvent not returning empty handles.

There are several codepaths where this is the expected result: * Other threads disabling the category in question. * The TraceBuffer being fill and no new chunks available. * Perfetto being active as the tracing backend. In all cases, the single use of a handle to a TraceEvent is TraceLog::UpdateTraceEventDuration which handles the above cases correctly. BUG=844421 Change-Id: Ieaf3aa5c913cee8c51cfea637907d5bc3b560ceb Reviewed-on: https://chromium-review.googlesource.com/1120841Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 1266d20a
...@@ -45,7 +45,6 @@ angle::TraceEventHandle AddTraceEvent(char phase, ...@@ -45,7 +45,6 @@ angle::TraceEventHandle AddTraceEvent(char phase,
angle::TraceEventHandle handle = angle::TraceEventHandle handle =
platform->addTraceEvent(platform, phase, categoryGroupEnabled, name, id, timestamp, platform->addTraceEvent(platform, phase, categoryGroupEnabled, name, id, timestamp,
numArgs, argNames, argTypes, argValues, flags); numArgs, argNames, argTypes, argValues, flags);
ASSERT(handle != 0);
return handle; return handle;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment