Skip to content

A
angle
Commit 33fb6e38 by Mohan Maiya Committed by Commit Bot
Options

Vulkan: Unskip tests with passthrough GLSL function

The 2 end2end tests added by a62ee4d1 no longer fail with latest Pixel ICDs. Enable those tests as regression checks. Tests: angle_end2end_tests --gtest_filter=*SamplerPassthrough*Vulkan* Bug: angleproject:5457 Change-Id: I53fb06fffa3fc76ef6f9a9e811ef5b833577ed67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2595389Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
parent 34383894
Showing with 4 additions and 12 deletions
src/tests/gl_tests/GLSLTest.cpp
...@@ -5081,15 +5081,10 @@ TEST_P(GLSLTest_ES3, VaryingStructUsedInFragmentShader) ...@@ -5081,15 +5081,10 @@ TEST_P(GLSLTest_ES3, VaryingStructUsedInFragmentShader)
EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green); EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
} }
// This test demonstrates an issue with shaders on the Pixel device's vulkan backend. // This is a regression test to make sure a red quad is rendered without issues
// This test should render a red quad without issues but on a Pixel4XL this test causes // when a passthrough function with a vec3 input parameter is used in the fragment shader.
// vkCreateGraphicPipelines to return VK_INCOMPLETE. logcat shows these messages:
// > Adreno : Failed to link shaders.
// > Internal Vulkan error: A return array was too small for the result
TEST_P(GLSLTest_ES31, SamplerPassthroughFailedLink) TEST_P(GLSLTest_ES31, SamplerPassthroughFailedLink)
{ {
// TODO: (anglebug.com/5457)
ANGLE_SKIP_TEST_IF(IsAndroid() && (IsPixel2() || IsPixel2XL()) && IsVulkan());
constexpr char kVS[] = constexpr char kVS[] =
"precision mediump float;\n" "precision mediump float;\n"
"attribute vec4 inputAttribute;\n" "attribute vec4 inputAttribute;\n"
...@@ -5125,13 +5120,10 @@ TEST_P(GLSLTest_ES31, SamplerPassthroughFailedLink) ...@@ -5125,13 +5120,10 @@ TEST_P(GLSLTest_ES31, SamplerPassthroughFailedLink)
EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::red); EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::red);
} }
// This test demonstrates issues with shaders on the Pixel device's vulkan backend. // This is a regression test to make sure a red quad is rendered without issues
// This test should render a red quad without issues but on a Pixel4XL it renders // when a passthrough function with a vec4 input parameter is used in the fragment shader.
// a black quad
TEST_P(GLSLTest_ES31, SamplerPassthroughIncorrectColor) TEST_P(GLSLTest_ES31, SamplerPassthroughIncorrectColor)
{ {
// TODO: (anglebug.com/5457)
ANGLE_SKIP_TEST_IF(IsAndroid() && (IsPixel2() || IsPixel2XL()) && IsVulkan());
constexpr char kVS[] = constexpr char kVS[] =
"precision mediump float;\n" "precision mediump float;\n"
"attribute vec4 inputAttribute;\n" "attribute vec4 inputAttribute;\n"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment