Commit 340da145 by Shahbaz Youssefi Committed by Commit Bot

Vulkan: Disable 1xMSAA on integer formats too

This was pending swiftshader support for 4xMSAA support for integer formats, which is long done. Bug: angleproject:4197 Change-Id: I843a9674e20a48b5387bd67b8c0efc8617841382 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2248198 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: 's avatarIan Elliott <ianelliott@google.com>
parent 51487e1e
......@@ -217,11 +217,8 @@ void RendererVk::ensureCapsInitialized() const
limitsVk.sampledImageColorSampleCounts & vk_gl::kSupportedSampleCounts;
mNativeCaps.maxDepthTextureSamples =
limitsVk.sampledImageDepthSampleCounts & vk_gl::kSupportedSampleCounts;
// TODO (ianelliott): Should mask this with vk_gl::kSupportedSampleCounts, but it causes
// end2end test failures with SwiftShader because SwiftShader returns a sample count of 1 in
// sampledImageIntegerSampleCounts.
// See: http://anglebug.com/4197
mNativeCaps.maxIntegerSamples = limitsVk.sampledImageIntegerSampleCounts;
mNativeCaps.maxIntegerSamples =
limitsVk.sampledImageIntegerSampleCounts & vk_gl::kSupportedSampleCounts;
mNativeCaps.maxVertexAttributes = LimitToInt(limitsVk.maxVertexInputAttributes);
mNativeCaps.maxVertexAttribBindings = LimitToInt(limitsVk.maxVertexInputBindings);
......
......@@ -50,6 +50,9 @@ class RenderbufferMultisampleTest : public ANGLETest
// MAX_INTEGER_SAMPLES should be at least 1.
TEST_P(RenderbufferMultisampleTest, IntegerInternalformat)
{
// Fixed in recent mesa. http://crbug.com/1071142
ANGLE_SKIP_TEST_IF(IsVulkan() && IsLinux() && (IsIntel() || IsAMD()));
glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
glRenderbufferStorageMultisample(GL_RENDERBUFFER, 1, GL_RGBA8I, 64, 64);
if (getClientMajorVersion() < 3 || getClientMinorVersion() < 1)
......
......@@ -358,6 +358,10 @@ TEST_P(TextureMultisampleTest, ValidateTextureStorageMultisampleParameters)
TEST_P(TextureMultisampleTest, MaxIntegerSamples)
{
ANGLE_SKIP_TEST_IF(lessThanES31MultisampleExtNotSupported());
// Fixed in recent mesa. http://crbug.com/1071142
ANGLE_SKIP_TEST_IF(IsVulkan() && IsLinux() && (IsIntel() || IsAMD()));
GLint maxIntegerSamples;
glGetIntegerv(GL_MAX_INTEGER_SAMPLES, &maxIntegerSamples);
EXPECT_GE(maxIntegerSamples, 1);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment