translator: Fix ASSERT in array init corner case.

src/compiler/translator/ParseContext.cpp

@@ -686,8 +686,12 @@ bool TParseContext::checkConstructorArguments(const TSourceLoc &line,
         for (TIntermNode *const &argNode : *arguments)
         {
             const TType &argType = argNode->getAsTyped()->getType();
-            // It has already been checked that the argument is not an array.
-            ASSERT(!argType.isArray());
+            // It has already been checked that the argument is not an array, but we can arrive
+            // here due to prior error conditions.
+            if (argType.isArray())
+            {
+                return false;
+            }
             if (!argType.sameElementType(type))
             {
                 error(line, "Array constructor argument has an incorrect type", "constructor");

src/tests/compiler_tests/ShaderValidation_test.cpp

@@ -3447,3 +3447,20 @@ TEST_F(FragmentShaderValidationTest, SamplerFieldStructUnsizedArrayEmptyConstruc
         FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
     }
 }
+
+// Checks that odd array initialization syntax is an error, and does not produce
+// an ASSERT failure.
+TEST_F(VertexShaderValidationTest, InvalidArrayConstruction)
+{
+    const std::string &shaderString =
+        "struct S { mediump float i; mediump int ggb; };\n"
+        "void main() {\n"
+        "  S s[2];\n"
+        "  s = S[](s.x, 0.0);\n"
+        "  gl_Position = vec4(1, 0, 0, 1);\n"
+        "}";
+    if (compile(shaderString))
+    {
+        FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
+    }
+}