Increase demangled array size

The call to abi::__cxa_demangle() with too small of a char[] can cause segfaults or hangs. This change increases the array from 256 to 4096. Bug: angleproject:3553 Test: Verify validation layers don't segfault/hang Change-Id: I6704ff00bfab62c99eb288f803ccda35a037dd9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670580Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>

Increase demangled array size
351e8098 · Tim Van Patten · Commit Bot · 87748543 · 351e8098
Commit 351e8098 authored Jun 21, 2019 by Tim Van Patten Committed by Commit Bot Jun 21, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

Posix_crash_handler.cpp util/posix/Posix_crash_handler.cpp +4 -1

No files found.
--- a/util/posix/Posix_crash_handler.cpp
+++ b/util/posix/Posix_crash_handler.cpp
@@ -107,7 +107,10 @@ void PrintStackBacktrace()
        Dl_info info;
        if (dladdr(stack[i], &info) && info.dli_sname)
        {
-            char demangled[256];
+            // Make sure this is large enough to hold the fully demangled names, otherwise we could
+            // segault/hang here. For example, Vulkan validation layer errors can be deep enough
+            // into the stack that very large symbol names are generated.
+            char demangled[4096];
            size_t len = ArraySize(demangled);
            int ok;