Commit 36b73909 by Olli Etuaho

Fix standalone ninja build on Linux

Preprocessor conditions referring to undefined macros failed standalone build which uses the -Werror=undef setting. This same error has been in multiple patches, and reverting them would cause test breakage, so fixing the issue is simpler than reverting. Change-Id: I4a079ef5d823eed76ebdefa8be413f63d29a5f6a Reviewed-on: https://chromium-review.googlesource.com/304020Reviewed-by: 's avatarOlli Etuaho <oetuaho@nvidia.com> Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
parent 5f579b1b
...@@ -574,7 +574,7 @@ void GenerateWorkarounds(const FunctionsGL *functions, WorkaroundsGL *workaround ...@@ -574,7 +574,7 @@ void GenerateWorkarounds(const FunctionsGL *functions, WorkaroundsGL *workaround
functions->standard == STANDARD_GL_DESKTOP && functions->standard == STANDARD_GL_DESKTOP &&
(vendor == VENDOR_ID_INTEL || vendor == VENDOR_ID_AMD); (vendor == VENDOR_ID_INTEL || vendor == VENDOR_ID_AMD);
#if ANGLE_PLATFORM_APPLE #if defined(ANGLE_PLATFORM_APPLE)
workarounds->doWhileGLSLCausesGPUHang = true; workarounds->doWhileGLSLCausesGPUHang = true;
#endif #endif
} }
......
...@@ -259,7 +259,7 @@ TEST_P(ClearTestES3, SRGBClear) ...@@ -259,7 +259,7 @@ TEST_P(ClearTestES3, SRGBClear)
TEST_P(ClearTestES3, MixedSRGBClear) TEST_P(ClearTestES3, MixedSRGBClear)
{ {
// TODO(cwallez) figure out why it is broken on Intel on Mac // TODO(cwallez) figure out why it is broken on Intel on Mac
#if ANGLE_PLATFORM_APPLE #if defined(ANGLE_PLATFORM_APPLE)
if (isIntel() && getPlatformRenderer() == EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE) if (isIntel() && getPlatformRenderer() == EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE)
{ {
std::cout << "Test skipped on Intel on Mac." << std::endl; std::cout << "Test skipped on Intel on Mac." << std::endl;
......
...@@ -150,7 +150,7 @@ TEST_P(PackUnpackTest, PackUnpackSnormNormal) ...@@ -150,7 +150,7 @@ TEST_P(PackUnpackTest, PackUnpackSnormNormal)
TEST_P(PackUnpackTest, PackUnpackHalfNormal) TEST_P(PackUnpackTest, PackUnpackHalfNormal)
{ {
// TODO(cwallez) figure out why it is broken on Intel on Mac // TODO(cwallez) figure out why it is broken on Intel on Mac
#if ANGLE_PLATFORM_APPLE #if defined(ANGLE_PLATFORM_APPLE)
if (isIntel() && getPlatformRenderer() == EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE) if (isIntel() && getPlatformRenderer() == EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE)
{ {
std::cout << "Test skipped on Intel on Mac." << std::endl; std::cout << "Test skipped on Intel on Mac." << std::endl;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment