Fix missing return values in bitset_utils.h

src/common/bitset_utils.h

@@ -30,7 +30,11 @@ class BitSetT final
     {
       public:
         ~Reference() {}
-        Reference &operator=(bool x) { mParent->set(mBit, x); }
+        Reference &operator=(bool x)
+        {
+            mParent->set(mBit, x);
+            return *this;
+        }
         operator bool() const { return mParent->test(mBit); }
 
       private:

src/common/bitset_utils_unittest.cpp

@@ -89,4 +89,24 @@ TEST_F(BitSetIteratorTest, NonLValueBitset)
     EXPECT_EQ((mStateBits & otherBits).count(), seenBits.size());
 }
 
+// Test bit assignments.
+TEST_F(BitSetIteratorTest, BitAssignment)
+{
+    std::set<size_t> originalValues;
+    originalValues.insert(2);
+    originalValues.insert(6);
+    originalValues.insert(8);
+    originalValues.insert(35);
+
+    for (size_t value : originalValues)
+    {
+        (mStateBits[value] = false) = true;
+    }
+
+    for (size_t value : originalValues)
+    {
+        EXPECT_TRUE(mStateBits.test(value));
+    }
+}
+
 }  // anonymous namespace