Skip to content

A
angle
Commit 3846cff3 by Yuly Novikov Committed by Commit Bot
Options

Suppress headers includes privacy checks on iOS

shared libraries are hidden inside ios_framework_bundle, so technically we are not allowed to include headers from them. Ignore this check since everything works fine besides "gn gen --check". All ANGLE headers are considered public, so we don't need this check. Bug: angleproject:5417 Change-Id: I6b621132dfe85e0fb1bea4ae2b93097945a8801a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643859Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
parent e60ce3da
Showing with 17 additions and 0 deletions
gni/angle.gni
...@@ -289,6 +289,10 @@ template("angle_shared_library") { ...@@ -289,6 +289,10 @@ template("angle_shared_library") {
} }
if (is_ios) { if (is_ios) {
info_plist = "$angle_root/util/ios/Info.plist" info_plist = "$angle_root/util/ios/Info.plist"
# shared libraries are hidden inside ios_framework_bundle, but we include headers from them
# Specifically, libGLESv1_CM includes headers from libGLESv2
check_includes = false
} }
} }
if (is_ios) { if (is_ios) {
...@@ -356,6 +360,11 @@ if (angle_standalone || build_with_chromium) { ...@@ -356,6 +360,11 @@ if (angle_standalone || build_with_chromium) {
configs += invoker.configs configs += invoker.configs
configs -= invoker.suppressed_configs configs -= invoker.suppressed_configs
if (is_ios) {
# shared libraries are hidden inside ios_framework_bundle, but we include headers from them
check_includes = false
}
public_deps = invoker.public_deps + [ public_deps = invoker.public_deps + [
"$angle_root:angle_common", "$angle_root:angle_common",
"$angle_root:includes", "$angle_root:includes",
......
src/tests/BUILD.gn
...@@ -64,6 +64,10 @@ template("angle_common_test_utils") { ...@@ -64,6 +64,10 @@ template("angle_common_test_utils") {
assert(defined(invoker.angle_util)) assert(defined(invoker.angle_util))
angle_source_set(target_name) { angle_source_set(target_name) {
testonly = true testonly = true
if (is_ios) {
# shared libraries are hidden inside ios_framework_bundle, but we include headers from them
check_includes = false
}
public_configs = [ public_configs = [
":angle_common_test_utils_config", ":angle_common_test_utils_config",
"$angle_root:library_name_config", "$angle_root:library_name_config",
...@@ -263,6 +267,10 @@ template("angle_perftests_common") { ...@@ -263,6 +267,10 @@ template("angle_perftests_common") {
angle_source_set(target_name) { angle_source_set(target_name) {
testonly = true testonly = true
if (is_ios) {
# shared libraries are hidden inside ios_framework_bundle, but we include headers from them
check_includes = false
}
sources = [ sources = [
"../third_party/trace_event/trace_event.h", "../third_party/trace_event/trace_event.h",
"perf_tests/ANGLEPerfTest.cpp", "perf_tests/ANGLEPerfTest.cpp",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment