Skip to content

A
angle
Commit 38ef7955 by Jamie Madill Committed by Commit Bot
Options

Drop isolated perf output arg in test runner.

This argument isn't used and is in the process of being removed. We need to remove it partially to unblock landing ANGLE tests in Chrome. We can follow up later to remove it from the argument set. Bug: angleproject:3162 Change-Id: I3f80eb1bc14fd93a2b6d9732e51f49873fabb27e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441512 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org> Reviewed-by: 's avatarDirk Pranke <dpranke@google.com>
parent 91b819a9
Showing with 1 addition and 4 deletions
scripts/run_gtest_angle_test.py
...@@ -58,6 +58,7 @@ def main(): ...@@ -58,6 +58,7 @@ def main():
parser = argparse.ArgumentParser() parser = argparse.ArgumentParser()
parser.add_argument('executable', help='Test executable.') parser.add_argument('executable', help='Test executable.')
parser.add_argument('--isolated-script-test-output', type=str, required=True) parser.add_argument('--isolated-script-test-output', type=str, required=True)
# TODO(jmadill): Remove when removed from the recipes. http://anglebug.com/3162
parser.add_argument('--isolated-script-test-perf-output', type=str, required=False) parser.add_argument('--isolated-script-test-perf-output', type=str, required=False)
parser.add_argument('--isolated-script-test-filter', type=str, required=False) parser.add_argument('--isolated-script-test-filter', type=str, required=False)
parser.add_argument('--xvfb', help='Start xvfb.', action='store_true') parser.add_argument('--xvfb', help='Start xvfb.', action='store_true')
...@@ -85,10 +86,6 @@ def main(): ...@@ -85,10 +86,6 @@ def main():
extra_flags.append('--isolated-script-test-output=%s' % extra_flags.append('--isolated-script-test-output=%s' %
args.isolated_script_test_output) args.isolated_script_test_output)
if args.isolated_script_test_perf_output:
extra_flags.append('--isolated-script-test-perf-output=%s' %
args.isolated_script_test_perf_output)
if args.isolated_script_test_filter: if args.isolated_script_test_filter:
filter_list = common.extract_filter_list(args.isolated_script_test_filter) filter_list = common.extract_filter_list(args.isolated_script_test_filter)
extra_flags.append('--gtest_filter=' + ':'.join(filter_list)) extra_flags.append('--gtest_filter=' + ':'.join(filter_list))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment