Lowered the severity of EOF_IN_DIRECTIVE from an ERROR to WARNING. There are…

Lowered the severity of EOF_IN_DIRECTIVE from an ERROR to WARNING. There are just too many shaders on internet (including webgl conformance test) that do not have a newline at the end of directives, especially #endif. Review URL: https://codereview.appspot.com/6352059 git-svn-id: https://angleproject.googlecode.com/svn/trunk@1185 736b8ea6-26fd-11df-bfd4-992fa37f6226

Lowered the severity of EOF_IN_DIRECTIVE from an ERROR to WARNING. There are…
390209ae · alokp@chromium.org · d0d9f87a · 390209ae · 390209ae
Commit 390209ae authored Jul 03, 2012 by alokp@chromium.org
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

Diagnostics.cpp src/compiler/preprocessor/new/Diagnostics.cpp +2 -2

Diagnostics.h src/compiler/preprocessor/new/Diagnostics.h +1 -1

No files found.
--- a/src/compiler/preprocessor/new/Diagnostics.cpp
+++ b/src/compiler/preprocessor/new/Diagnostics.cpp
@@ -60,8 +60,6 @@ std::string Diagnostics::message(ID id)
          return "division by zero";
      case EOF_IN_COMMENT:
          return "unexpected end of file found in comment";
-      case EOF_IN_DIRECTIVE:
-          return "unexpected end of file found in directive";
      case UNEXPECTED_TOKEN:
          return "unexpected token";
      case DIRECTIVE_INVALID_NAME:
@@ -113,6 +111,8 @@ std::string Diagnostics::message(ID id)
          return "invalid line directive";
      // Errors end.
      // Warnings begin.
+      case EOF_IN_DIRECTIVE:
+          return "unexpected end of file found in directive";
      case CONDITIONAL_UNEXPECTED_TOKEN:
          return "unexpected token after conditional expression";
      case UNRECOGNIZED_PRAGMA:

--- a/src/compiler/preprocessor/new/Diagnostics.h
+++ b/src/compiler/preprocessor/new/Diagnostics.h
@@ -37,7 +37,6 @@ class Diagnostics
        INVALID_EXPRESSION,
        DIVISION_BY_ZERO,
        EOF_IN_COMMENT,
-        EOF_IN_DIRECTIVE,
        UNEXPECTED_TOKEN,
        DIRECTIVE_INVALID_NAME,
        MACRO_NAME_RESERVED,
@@ -65,6 +64,7 @@ class Diagnostics
        ERROR_END,

        WARNING_BEGIN,
+        EOF_IN_DIRECTIVE,
        CONDITIONAL_UNEXPECTED_TOKEN,
        UNRECOGNIZED_PRAGMA,
        WARNING_END