Lexer does not need to handle unknown-char case.

It is handled by the preprocessor. Added an assert. TRAC #23158 Signed-off-by: Nicolas Capens Merged-by: Jamie Madill Authored-by: alokp@chromium.org git-svn-url: https://code.google.com/p/angleproject/source/detail?r=2194 Review URL: https://codereview.appspot.com/8653052

Lexer does not need to handle unknown-char case.
39a8ce6b · Jamie Madill · Shannon Woods · 96de824e · 39a8ce6b · 39a8ce6b
Commit 39a8ce6b authored Jun 13, 2013 by Jamie Madill Committed by Shannon Woods Jul 19, 2013
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 5 deletions

glslang.l src/compiler/glslang.l +3 -3

glslang_lex.cpp src/compiler/glslang_lex.cpp +2 -2

No files found.
--- a/src/compiler/glslang.l
+++ b/src/compiler/glslang.l
@@ -364,9 +364,9 @@ O           [0-7]
 }
 <FIELDS>[ \t\v\f\r] {}
-[ \t\v\n\f\r]   {  }
+[ \t\v\n\f\r] { }
-<*><<EOF>>      { yyterminate(); }
+<*><<EOF>>    { yyterminate(); }
-<*>.            { context->warning(yylineno, "Unknown char", yytext, ""); return 0; }
+<*>.          { assert(false); return 0; }
 %%

--- a/src/compiler/glslang_lex.cpp
+++ b/src/compiler/glslang_lex.cpp
@@ -1961,7 +1961,7 @@ YY_RULE_SETUP
 case 226:
 /* rule 226 can match eol */
 YY_RULE_SETUP
-{  }
+{ }
 	YY_BREAK
 case YY_STATE_EOF(INITIAL):
 case YY_STATE_EOF(FIELDS):
@@ -1969,7 +1969,7 @@ case YY_STATE_EOF(FIELDS):
 	YY_BREAK
 case 227:
 YY_RULE_SETUP
-{ context->warning(yylineno, "Unknown char", yytext, ""); return 0; }
+{ assert(false); return 0; }
 	YY_BREAK
 case 228:
 YY_RULE_SETUP