Skip to content

A
angle
Commit 3a2e01ed by Jamie Madill Committed by Commit Bot
Options

Vulkan: Require sampling support for attachments.

Since Framebuffer attachments can be copied from with CopyTexImage, we must require transfer support. This will affect the amount of formats we can expose correctly for different uses. Bug: angleproject:3876 Change-Id: I0343da94b5f8e05dca946e7029ffb8fdf155bb41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1803756 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent 8f08fed9
Showing with 6 additions and 1 deletion
src/libANGLE/renderer/vulkan/vk_format_utils.cpp
...@@ -32,8 +32,13 @@ void FillTextureFormatCaps(RendererVk *renderer, VkFormat format, gl::TextureCap ...@@ -32,8 +32,13 @@ void FillTextureFormatCaps(RendererVk *renderer, VkFormat format, gl::TextureCap
renderer->hasImageFormatFeatureBits(format, VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT); renderer->hasImageFormatFeatureBits(format, VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT);
outTextureCaps->filterable = renderer->hasImageFormatFeatureBits( outTextureCaps->filterable = renderer->hasImageFormatFeatureBits(
format, VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT); format, VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT);
// For renderbuffer and texture attachments we require transfer and sampling for
// GLES 2.0 CopyTexImage support. Sampling is also required for other features like
// blits and EGLImages.
outTextureCaps->textureAttachment = outTextureCaps->textureAttachment =
hasColorAttachmentFeatureBit || hasDepthAttachmentFeatureBit; outTextureCaps->texturable &&
(hasColorAttachmentFeatureBit || hasDepthAttachmentFeatureBit);
outTextureCaps->renderbuffer = outTextureCaps->textureAttachment; outTextureCaps->renderbuffer = outTextureCaps->textureAttachment;
if (outTextureCaps->renderbuffer) if (outTextureCaps->renderbuffer)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment