Commit 3a7cdb82 by Geoff Lang Committed by Commit Bot

"Implement" more NULL backend objects.

BUG=angleproject:1468 Change-Id: I3c42872ba13dbf346722bc34b9415a4e79c9f82c Reviewed-on: https://chromium-review.googlesource.com/413328 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
parent a96afb68
...@@ -24,26 +24,23 @@ FenceSyncNULL::~FenceSyncNULL() ...@@ -24,26 +24,23 @@ FenceSyncNULL::~FenceSyncNULL()
gl::Error FenceSyncNULL::set(GLenum condition, GLbitfield flags) gl::Error FenceSyncNULL::set(GLenum condition, GLbitfield flags)
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
gl::Error FenceSyncNULL::clientWait(GLbitfield flags, GLuint64 timeout, GLenum *outResult) gl::Error FenceSyncNULL::clientWait(GLbitfield flags, GLuint64 timeout, GLenum *outResult)
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
gl::Error FenceSyncNULL::serverWait(GLbitfield flags, GLuint64 timeout) gl::Error FenceSyncNULL::serverWait(GLbitfield flags, GLuint64 timeout)
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
gl::Error FenceSyncNULL::getStatus(GLint *outResult) gl::Error FenceSyncNULL::getStatus(GLint *outResult)
{ {
UNIMPLEMENTED(); *outResult = GL_SIGNALED;
return gl::Error(GL_INVALID_OPERATION); return gl::NoError();
} }
} // namespace rx } // namespace rx
...@@ -163,15 +163,16 @@ void ProgramNULL::setUniformBlockBinding(GLuint uniformBlockIndex, GLuint unifor ...@@ -163,15 +163,16 @@ void ProgramNULL::setUniformBlockBinding(GLuint uniformBlockIndex, GLuint unifor
bool ProgramNULL::getUniformBlockSize(const std::string &blockName, size_t *sizeOut) const bool ProgramNULL::getUniformBlockSize(const std::string &blockName, size_t *sizeOut) const
{ {
UNIMPLEMENTED(); // TODO(geofflang): Compute reasonable sizes?
return bool(); *sizeOut = 0;
return true;
} }
bool ProgramNULL::getUniformBlockMemberInfo(const std::string &memberUniformName, bool ProgramNULL::getUniformBlockMemberInfo(const std::string &memberUniformName,
sh::BlockMemberInfo *memberInfoOut) const sh::BlockMemberInfo *memberInfoOut) const
{ {
UNIMPLEMENTED(); // TODO(geofflang): Compute reasonable values?
return bool(); return true;
} }
void ProgramNULL::setPathFragmentInputGen(const std::string &inputName, void ProgramNULL::setPathFragmentInputGen(const std::string &inputName,
......
...@@ -24,50 +24,47 @@ QueryNULL::~QueryNULL() ...@@ -24,50 +24,47 @@ QueryNULL::~QueryNULL()
gl::Error QueryNULL::begin() gl::Error QueryNULL::begin()
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
gl::Error QueryNULL::end() gl::Error QueryNULL::end()
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
gl::Error QueryNULL::queryCounter() gl::Error QueryNULL::queryCounter()
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
gl::Error QueryNULL::getResult(GLint *params) gl::Error QueryNULL::getResult(GLint *params)
{ {
UNIMPLEMENTED(); *params = 0;
return gl::Error(GL_INVALID_OPERATION); return gl::NoError();
} }
gl::Error QueryNULL::getResult(GLuint *params) gl::Error QueryNULL::getResult(GLuint *params)
{ {
UNIMPLEMENTED(); *params = 0;
return gl::Error(GL_INVALID_OPERATION); return gl::NoError();
} }
gl::Error QueryNULL::getResult(GLint64 *params) gl::Error QueryNULL::getResult(GLint64 *params)
{ {
UNIMPLEMENTED(); *params = 0;
return gl::Error(GL_INVALID_OPERATION); return gl::NoError();
} }
gl::Error QueryNULL::getResult(GLuint64 *params) gl::Error QueryNULL::getResult(GLuint64 *params)
{ {
UNIMPLEMENTED(); *params = 0;
return gl::Error(GL_INVALID_OPERATION); return gl::NoError();
} }
gl::Error QueryNULL::isResultAvailable(bool *available) gl::Error QueryNULL::isResultAvailable(bool *available)
{ {
UNIMPLEMENTED(); *available = true;
return gl::Error(GL_INVALID_OPERATION); return gl::NoError();
} }
} // namespace rx } // namespace rx
...@@ -24,8 +24,7 @@ RenderbufferNULL::~RenderbufferNULL() ...@@ -24,8 +24,7 @@ RenderbufferNULL::~RenderbufferNULL()
gl::Error RenderbufferNULL::setStorage(GLenum internalformat, size_t width, size_t height) gl::Error RenderbufferNULL::setStorage(GLenum internalformat, size_t width, size_t height)
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
gl::Error RenderbufferNULL::setStorageMultisample(size_t samples, gl::Error RenderbufferNULL::setStorageMultisample(size_t samples,
...@@ -33,14 +32,12 @@ gl::Error RenderbufferNULL::setStorageMultisample(size_t samples, ...@@ -33,14 +32,12 @@ gl::Error RenderbufferNULL::setStorageMultisample(size_t samples,
size_t width, size_t width,
size_t height) size_t height)
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
gl::Error RenderbufferNULL::setStorageEGLImageTarget(egl::Image *image) gl::Error RenderbufferNULL::setStorageEGLImageTarget(egl::Image *image)
{ {
UNIMPLEMENTED(); return gl::NoError();
return gl::Error(GL_INVALID_OPERATION);
} }
} // namespace rx } // namespace rx
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment