Skip to content

A
angle
Commit 3ad467df by Jamie Madill
Options

Remove shared_utils.h, use angle_common instead.

This saves us from needing to replicate the same code in two places. BUG=angleproject:956 Change-Id: Ibc80997eec184d0d5aa9c6c076c9d4507fbf8caa Reviewed-on: https://chromium-review.googlesource.com/262776Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Reviewed-by: 's avatarBrandon Jones <bajones@chromium.org> Tested-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 9bd4dbef
Showing with 22 additions and 39 deletions
samples/samples.gyp
......@@ -52,13 +52,17 @@
'includes': [ '../build/common_defines.gypi', ],
'dependencies':
[
'../src/angle.gyp:libEGL',
'../src/angle.gyp:libGLESv2',
'../util/util.gyp:angle_util',
'<(angle_path)/src/angle.gyp:libEGL',
'<(angle_path)/src/angle.gyp:libGLESv2',
'<(angle_path)/util/util.gyp:angle_util',
],
'export_dependent_settings':
[
'<(angle_path)/util/util.gyp:angle_util',
],
'include_dirs':
[
'../include',
'<(angle_path)/include',
'angle/sample_util',
],
'sources':
......@@ -71,9 +75,7 @@
'msvs_disabled_warnings': [ 4201 ],
'include_dirs':
[
'../include',
'angle/sample_util',
'../util',
],
},
},
......
src/tests/end2end_tests/ANGLETest.h
......@@ -14,7 +14,7 @@
#include "angle_gl.h"
#include <algorithm>
#include "shared_utils.h"
#include "common/angleutils.h"
#include "shader_utils.h"
#include "testfixturetypes.h"
......
src/tests/perf_tests/ANGLEPerfTest.h
......@@ -20,7 +20,7 @@
#include "EGLWindow.h"
#include "OSWindow.h"
#include "Timer.h"
#include "shared_utils.h"
#include "common/angleutils.h"
class Event;
......
util/EGLWindow.h
......@@ -21,7 +21,7 @@
#include <cstdint>
#include <memory>
#include "shared_utils.h"
#include "common/angleutils.h"
class OSWindow;
......
util/shared_utils.h deleted 100644 → 0
//
// Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#ifndef UTIL_SHARED_UTILS_H
#define UTIL_SHARED_UTILS_H
#define SHADER_SOURCE(...) #__VA_ARGS__
// A macro to disallow the copy constructor and operator= functions
// This must be used in the private: declarations for a class
#define DISALLOW_COPY_AND_ASSIGN(TypeName) \
TypeName(const TypeName&); \
void operator=(const TypeName&)
template <typename T, size_t N>
inline size_t ArraySize(T(&)[N])
{
return N;
}
#endif // UTIL_SHARED_UTILS_H
util/util.gyp
......@@ -15,13 +15,18 @@
'includes': [ '../build/common_defines.gypi', ],
'dependencies':
[
'../src/angle.gyp:libEGL',
'../src/angle.gyp:libGLESv2',
'<(angle_path)/src/angle.gyp:angle_common',
'<(angle_path)/src/angle.gyp:libEGL',
'<(angle_path)/src/angle.gyp:libGLESv2',
],
'export_dependent_settings':
[
'<(angle_path)/src/angle.gyp:angle_common',
],
'include_dirs':
[
'../include',
'.',
'<(angle_path)/include',
'<(angle_path)/util',
],
'sources':
[
......@@ -32,7 +37,6 @@
'random_utils.h',
'shader_utils.cpp',
'shader_utils.h',
'shared_utils.h',
'testfixturetypes.h',
'EGLWindow.cpp',
'EGLWindow.h',
......@@ -51,7 +55,8 @@
{
'include_dirs':
[
'.',
'<(angle_path)/include',
'<(angle_path)/util',
],
},
},
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment