Commit 3b345ebd by Kenneth Russell

Fix ANGLE build on Chrome OS ARM.

These builders set use_x11=1 but don't have GLX headers. Avoid trying to compile ANGLE's GL, GLX and X11 sources on Chrome OS at all. BUG=503173,angleproject:892 Change-Id: I7f5862bb83b33f6ce302244fa5668295789a3a41 Reviewed-on: https://chromium-review.googlesource.com/281778Reviewed-by: 's avatarZhenyao Mo <zmo@chromium.org> Tested-by: 's avatarKenneth Russell <kbr@chromium.org>
parent 0eb0a816
...@@ -32,24 +32,6 @@ ...@@ -32,24 +32,6 @@
'-Wwrite-strings', '-Wwrite-strings',
'-Wno-format-nonliteral', '-Wno-format-nonliteral',
], ],
# Nested dictionnary hack to allow setting a default value for
# a variable and test it in the dict (merged in angle.gyp).
'variables':
{
'conditions':
[
['OS=="linux"',
{
'use_x11': 1,
},
{
'use_x11': 0,
}],
],
},
# Copy conditionally-set variables out one scope.
'use_x11%': '<(use_x11)',
}, },
'target_defaults': 'target_defaults':
{ {
......
...@@ -10,6 +10,15 @@ ...@@ -10,6 +10,15 @@
'angle_build_winrt%': '0', 'angle_build_winrt%': '0',
'angle_build_winphone%': '0', 'angle_build_winphone%': '0',
'angle_build_winrt_app_type_revision%': '8.1', 'angle_build_winrt_app_type_revision%': '8.1',
'conditions':
[
['OS=="linux" and use_x11==1 and chromeos==0', {
'angle_use_glx%': 1,
},
{
'angle_use_glx%': 0,
}],
],
}, },
'msvs_disabled_warnings': 'msvs_disabled_warnings':
[ [
......
...@@ -26,6 +26,10 @@ if __name__ == '__main__': ...@@ -26,6 +26,10 @@ if __name__ == '__main__':
# correct directory. This only has an effect on Linux. # correct directory. This only has an effect on Linux.
args.append('--depth'); args.append('--depth');
args.append('.'); args.append('.');
# Add standalone.gypi to the include path to set required
# variables that are otherwise picked up from Chromium's gyp
# files.
args.append('-I' + os.path.join(script_dir, 'standalone.gypi'))
# Add common.gypi to the include path. # Add common.gypi to the include path.
args.append('-I' + os.path.join(script_dir, 'common.gypi')) args.append('-I' + os.path.join(script_dir, 'common.gypi'))
args.append('--no-parallel') args.append('--no-parallel')
......
# Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'variables':
{
# Assume for the time being that we're never compiling
# standalone ANGLE on Chrome OS.
'chromeos': 0,
# Use a nested variable trick to get use_x11 evaluated more
# eagerly than other conditional variables.
'variables':
{
'conditions':
[
['OS=="linux"',
{
'use_x11': 1,
},
{
'use_x11': 0,
}],
],
},
# Copy conditionally-set variables out one scope.
'use_x11%': '<(use_x11)',
},
}
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
'angle_enable_d3d11%': 1, 'angle_enable_d3d11%': 1,
'angle_enable_hlsl%': 1, 'angle_enable_hlsl%': 1,
}], }],
['OS=="linux" and use_x11==1', ['OS=="linux" and use_x11==1 and chromeos==0',
{ {
'angle_enable_gl%': 1, 'angle_enable_gl%': 1,
}], }],
......
...@@ -561,7 +561,7 @@ ...@@ -561,7 +561,7 @@
], ],
'conditions': 'conditions':
[ [
['use_x11==1', ['angle_use_glx==1',
{ {
'defines': 'defines':
[ [
...@@ -679,7 +679,7 @@ ...@@ -679,7 +679,7 @@
'<@(libangle_gl_wgl_sources)', '<@(libangle_gl_wgl_sources)',
], ],
}], }],
['use_x11==1', ['angle_use_glx==1',
{ {
'defines': 'defines':
[ [
...@@ -771,7 +771,7 @@ ...@@ -771,7 +771,7 @@
{ {
'msvs_enable_winphone' : '1', 'msvs_enable_winphone' : '1',
}], }],
['use_x11==1', ['angle_use_glx==1',
{ {
'link_settings': { 'link_settings': {
'ldflags': [ 'ldflags': [
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment