Commit 3e1af85a by Gert Wollny Committed by Commit Bot

Capture/Replay: Handle bindGeneratesResource in trace meta data

Bug: angleproject:5844 Change-Id: I0243cab70b5833efd83b0d75a1801f68025ee291 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2835889 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
parent c1da2794
...@@ -1190,6 +1190,8 @@ void WriteCppReplayIndexFiles(bool compression, ...@@ -1190,6 +1190,8 @@ void WriteCppReplayIndexFiles(bool compression,
<< ";\n"; << ";\n";
header << "constexpr bool kAreClientArraysEnabled = " header << "constexpr bool kAreClientArraysEnabled = "
<< (context->getState().areClientArraysEnabled() ? "true" : "false") << ";\n"; << (context->getState().areClientArraysEnabled() ? "true" : "false") << ";\n";
header << "constexpr bool kbindGeneratesResources = "
<< (context->getState().isBindGeneratesResourceEnabled() ? "true" : "false") << ";\n";
header << "// End Trace Metadata\n"; header << "// End Trace Metadata\n";
header << "\n"; header << "\n";
......
...@@ -97,6 +97,7 @@ test_trace_info_init_template = """\ ...@@ -97,6 +97,7 @@ test_trace_info_init_template = """\
{namespace}::kDefaultFramebufferStencilBits, {namespace}::kDefaultFramebufferStencilBits,
{namespace}::kIsBinaryDataCompressed, {namespace}::kIsBinaryDataCompressed,
{namespace}::kAreClientArraysEnabled, {namespace}::kAreClientArraysEnabled,
{namespace}::kbindGeneratesResources,
}}, }},
""" """
...@@ -125,6 +126,7 @@ struct TestTraceInfo {{ ...@@ -125,6 +126,7 @@ struct TestTraceInfo {{
EGLint defaultFramebufferStencilBits; EGLint defaultFramebufferStencilBits;
bool isBinaryDataCompressed; bool isBinaryDataCompressed;
bool areClientArraysEnabled; bool areClientArraysEnabled;
bool bindGeneratesResources;
}}; }};
extern std::vector<TestTraceInfo> testTraceInfos; extern std::vector<TestTraceInfo> testTraceInfos;
......
...@@ -76,7 +76,8 @@ class CaptureReplayTests ...@@ -76,7 +76,8 @@ class CaptureReplayTests
configParams.depthBits = testTraceInfo.defaultFramebufferDepthBits; configParams.depthBits = testTraceInfo.defaultFramebufferDepthBits;
configParams.stencilBits = testTraceInfo.defaultFramebufferStencilBits; configParams.stencilBits = testTraceInfo.defaultFramebufferStencilBits;
configParams.clientArraysEnabled = testTraceInfo.areClientArraysEnabled; configParams.clientArraysEnabled = testTraceInfo.areClientArraysEnabled;
configParams.bindGeneratesResource = testTraceInfo.bindGeneratesResources;
mPlatformParams.renderer = testTraceInfo.replayPlatformType; mPlatformParams.renderer = testTraceInfo.replayPlatformType;
mPlatformParams.deviceType = testTraceInfo.replayDeviceType; mPlatformParams.deviceType = testTraceInfo.replayDeviceType;
......
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
# #
# Failed tests # Failed tests
BindGeneratesResourceTest.*
CopyTextureTestWebGL.NPOT/* CopyTextureTestWebGL.NPOT/*
D3DImageFormatConversionTest.* D3DImageFormatConversionTest.*
DifferentStencilMasksTest.* DifferentStencilMasksTest.*
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment