Make the sentinel value for glBindBufferBase whole-buffer binding zero instead…

Make the sentinel value for glBindBufferBase whole-buffer binding zero instead of -1, to harmonize with the spec. TRAC #22852 Signed-off-by: Geoff Lang Signed-off-by: Nicolas Capens Author: Jamie Madill git-svn-id: https://angleproject.googlecode.com/svn/branches/es3proto@2284 736b8ea6-26fd-11df-bfd4-992fa37f6226

Make the sentinel value for glBindBufferBase whole-buffer binding zero instead…
3eeca1ec · shannonwoods@chromium.org · 37b8a91a · 3eeca1ec · 3eeca1ec
Commit 3eeca1ec authored May 30, 2013 by shannonwoods@chromium.org
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

RefCountObject.h src/common/RefCountObject.h +2 -2

libGLESv2.cpp src/libGLESv2/libGLESv2.cpp +2 -2

No files found.
--- a/src/common/RefCountObject.h
+++ b/src/common/RefCountObject.h
@@ -67,13 +67,13 @@ template <class ObjectType>
 class OffsetBindingPointer : public RefCountObjectBindingPointer
 {
  public:
-    OffsetBindingPointer() : mOffset(0), mSize(-1) { }
+    OffsetBindingPointer() : mOffset(0), mSize(0) { }

    void set(ObjectType *newObject)
    {
        RefCountObjectBindingPointer::set(newObject);
        mOffset = 0;
-        mSize = -1;
+        mSize = 0;
    }

    void set(ObjectType *newObject, GLintptr offset, GLsizeiptr size)

--- a/src/libGLESv2/libGLESv2.cpp
+++ b/src/libGLESv2/libGLESv2.cpp
@@ -8737,12 +8737,12 @@ void __stdcall glBindBufferBase(GLenum target, GLuint index, GLuint buffer)
            switch (target)
            {
              case GL_TRANSFORM_FEEDBACK_BUFFER:
-                context->bindIndexedTransformFeedbackBuffer(buffer, index, 0, -1);
+                context->bindIndexedTransformFeedbackBuffer(buffer, index, 0, 0);
                context->bindGenericTransformFeedbackBuffer(buffer);
                break;

              case GL_UNIFORM_BUFFER:
-                context->bindIndexedUniformBuffer(buffer, index, 0, -1);
+                context->bindIndexedUniformBuffer(buffer, index, 0, 0);
                context->bindGenericUniformBuffer(buffer);
                break;