Commit 4210e49b by Alexis Hetu Committed by Commit Bot

Correct presubmit error for missing Bug ID

Having a Bug ID is not enough to silence this error, the Bug ID must be on the line directly above the Change ID line to prevent getting this error. Bug: angleproject:3992 Change-Id: I90ec1169efb77c1be6a1004e579f16e89115be50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1853604Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
parent 73872582
...@@ -32,8 +32,9 @@ def _CheckChangeHasBugField(input_api, output_api): ...@@ -32,8 +32,9 @@ def _CheckChangeHasBugField(input_api, output_api):
bugs = input_api.change.BugsFromDescription() bugs = input_api.change.BugsFromDescription()
if not bugs: if not bugs:
return [ return [
output_api.PresubmitError( output_api.PresubmitError('Please ensure that your description contains:\n'
'If this change has an associated bug, add Bug: angleproject:[bug number].') '"Bug: angleproject:[bug number]"\n'
'directly above the Change-Id tag.')
] ]
elif not all([' ' not in bug for bug in bugs]): elif not all([' ' not in bug for bug in bugs]):
return [ return [
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment