Skip to content

A
angle
Commit 43b4fefd by Tim Van Patten Committed by Commit Bot
Options

Revert "Vulkan: Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount"

This reverts commit a5db7d6e. Reason for revert: VVL rolled with the fix. Original change's description: > Vulkan: Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount > > Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount while the > Khronos issue is investigated. > > Bug: angleproject:5148 > Change-Id: If3cd4b028182a06411b928417e7c778ea02189d1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462075 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Tim Van Patten <timvp@google.com> TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5148 Change-Id: Ibb66370334554773dda3e849d0bc9f3e8f8577fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472997Reviewed-by: 's avatarTim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
parent 1ca0c2a9
Showing with 9 additions and 6 deletions
src/libANGLE/renderer/vulkan/RendererVk.cpp
...@@ -131,15 +131,19 @@ constexpr const char *kSkippedMessages[] = { ...@@ -131,15 +131,19 @@ constexpr const char *kSkippedMessages[] = {
"VUID-VkPipelineInputAssemblyStateCreateInfo-topology-00428", "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-00428",
// http://anglebug.com/4063 // http://anglebug.com/4063
"VUID-VkDeviceCreateInfo-pNext-pNext", "VUID-VkDeviceCreateInfo-pNext-pNext",
"VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext", "VUID_Undefined", "VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext",
"VUID_Undefined",
// https://issuetracker.google.com/issues/159493191 // https://issuetracker.google.com/issues/159493191
"VUID-vkCmdDraw-None-02690", "VUID-vkCmdDrawIndexed-None-02690", "VUID-vkCmdDraw-None-02690",
"VUID-vkCmdDrawIndexed-None-02690",
// http://anglebug.com/4975 // http://anglebug.com/4975
"VUID-vkCmdDraw-None-02687", "VUID-vkCmdDrawIndexed-None-02687", "VUID-vkCmdDraw-None-02687",
"VUID-vkCmdDrawIndexed-None-02687",
// Best Practices Skips https://issuetracker.google.com/issues/166641492 // Best Practices Skips https://issuetracker.google.com/issues/166641492
// https://issuetracker.google.com/issues/166793850 // https://issuetracker.google.com/issues/166793850
"UNASSIGNED-BestPractices-vkCreateCommandPool-command-buffer-reset", "UNASSIGNED-BestPractices-vkCreateCommandPool-command-buffer-reset",
"UNASSIGNED-BestPractices-pipeline-stage-flags", "UNASSIGNED-BestPractices-Error-Result", "UNASSIGNED-BestPractices-pipeline-stage-flags",
"UNASSIGNED-BestPractices-Error-Result",
"UNASSIGNED-BestPractices-vkAllocateMemory-small-allocation", "UNASSIGNED-BestPractices-vkAllocateMemory-small-allocation",
"UNASSIGNED-BestPractices-vkBindMemory-small-dedicated-allocation", "UNASSIGNED-BestPractices-vkBindMemory-small-dedicated-allocation",
"UNASSIGNED-BestPractices-vkAllocateMemory-too-many-objects", "UNASSIGNED-BestPractices-vkAllocateMemory-too-many-objects",
...@@ -152,8 +156,7 @@ constexpr const char *kSkippedMessages[] = { ...@@ -152,8 +156,7 @@ constexpr const char *kSkippedMessages[] = {
"VUID-vkMapMemory-memory-00683", "VUID-vkMapMemory-memory-00683",
// http://anglebug.com/5027 // http://anglebug.com/5027
"UNASSIGNED-CoreValidation-Shader-PushConstantOutOfRange", "UNASSIGNED-CoreValidation-Shader-PushConstantOutOfRange",
// http://anglebug.com/5148 };
"UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount"};
// Suppress validation errors that are known // Suppress validation errors that are known
// return "true" if given code/prefix/message is known, else return "false" // return "true" if given code/prefix/message is known, else return "false"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment