Skip to content

A
angle
Commit 44558e37 by Jamie Madill Committed by Commit Bot
Options

Vulkan: Enable TextureLimitsTest.

Seems to pass possibly because of a prior bug fix. Bug: angleproject:2654 Change-Id: I53e67bfa28e5429c51720fa71d9168d2f1cf1ece Reviewed-on: https://chromium-review.googlesource.com/1199928Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 73d15ba4
Showing with 0 additions and 12 deletions
src/tests/gl_tests/TextureTest.cpp
...@@ -2928,10 +2928,6 @@ TEST_P(TextureLimitsTest, MaxFragmentTextures) ...@@ -2928,10 +2928,6 @@ TEST_P(TextureLimitsTest, MaxFragmentTextures)
// Test rendering with maximum combined texture units. // Test rendering with maximum combined texture units.
TEST_P(TextureLimitsTest, MaxCombinedTextures) TEST_P(TextureLimitsTest, MaxCombinedTextures)
{ {
// TODO(lucferron): Diagnose and fix
// http://anglebug.com/2654
ANGLE_SKIP_TEST_IF(IsVulkan());
GLint vertexTextures = mMaxVertexTextures; GLint vertexTextures = mMaxVertexTextures;
if (vertexTextures + mMaxFragmentTextures > mMaxCombinedTextures) if (vertexTextures + mMaxFragmentTextures > mMaxCombinedTextures)
...@@ -2966,10 +2962,6 @@ TEST_P(TextureLimitsTest, ExcessiveFragmentTextures) ...@@ -2966,10 +2962,6 @@ TEST_P(TextureLimitsTest, ExcessiveFragmentTextures)
// Test active vertex textures under the limit, but excessive textures specified. // Test active vertex textures under the limit, but excessive textures specified.
TEST_P(TextureLimitsTest, MaxActiveVertexTextures) TEST_P(TextureLimitsTest, MaxActiveVertexTextures)
{ {
// TODO(lucferron): Diagnose and fix
// http://anglebug.com/2654
ANGLE_SKIP_TEST_IF(IsVulkan());
compileProgramWithTextureCounts("tex", mMaxVertexTextures + 4, mMaxVertexTextures, "tex", 0, 0); compileProgramWithTextureCounts("tex", mMaxVertexTextures + 4, mMaxVertexTextures, "tex", 0, 0);
ASSERT_NE(0u, mProgram); ASSERT_NE(0u, mProgram);
ASSERT_GL_NO_ERROR(); ASSERT_GL_NO_ERROR();
...@@ -2980,10 +2972,6 @@ TEST_P(TextureLimitsTest, MaxActiveVertexTextures) ...@@ -2980,10 +2972,6 @@ TEST_P(TextureLimitsTest, MaxActiveVertexTextures)
// Test active fragment textures under the limit, but excessive textures specified. // Test active fragment textures under the limit, but excessive textures specified.
TEST_P(TextureLimitsTest, MaxActiveFragmentTextures) TEST_P(TextureLimitsTest, MaxActiveFragmentTextures)
{ {
// TODO(lucferron): Diagnose and fix
// http://anglebug.com/2654
ANGLE_SKIP_TEST_IF(IsVulkan());
compileProgramWithTextureCounts("tex", 0, 0, "tex", mMaxFragmentTextures + 4, compileProgramWithTextureCounts("tex", 0, 0, "tex", mMaxFragmentTextures + 4,
mMaxFragmentTextures); mMaxFragmentTextures);
ASSERT_NE(0u, mProgram); ASSERT_NE(0u, mProgram);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment