Re-enable -Wextra-semi-stmt.

BUILD.gn

@@ -123,14 +123,12 @@ config("extra_warnings") {
   }
   if (is_clang) {
     cflags += [
-      # Enable after anglebug.com/3128 is fixed.
-      # "-Wextra-semi-stmt",
-
+      "-Wexit-time-destructors",
+      "-Wextra-semi-stmt",
       "-Wfloat-conversion",
+      "-Wglobal-constructors",
       "-Wnon-virtual-dtor",
       "-Wunneeded-internal-declaration",
-      "-Wglobal-constructors",
-      "-Wexit-time-destructors",
 
       # The below warnings are used by WebKit. We enable them to make rolling
       # ANGLE in WebKit easier.

src/libANGLE/renderer/vulkan/ImageVk.cpp

@@ -94,7 +94,6 @@ egl::Error ImageVk::initialize(const egl::Display *display)
 
             ASSERT(mContext != nullptr);
             renderer = vk::GetImpl(mContext)->getRenderer();
-            ;
         }
         else if (egl::IsExternalImageTarget(mState.target))
         {

src/third_party/trace_event/trace_event.h

@@ -475,17 +475,20 @@
 // Implementation detail: internal macro to create static category and add begin
 // event if the category is enabled. Also adds the end event when the scope
 // ends.
-#define INTERNAL_TRACE_EVENT_ADD_SCOPED(platform, category, name, ...)                 \
-    INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO(platform, category);                        \
-    gl::TraceEvent::TraceEndOnScopeClose INTERNALTRACEEVENTUID(profileScope);          \
-    if (*INTERNALTRACEEVENTUID(catstatic))                                             \
-    {                                                                                  \
-        gl::TraceEvent::addTraceEvent(                                                 \
-            platform, TRACE_EVENT_PHASE_BEGIN, INTERNALTRACEEVENTUID(catstatic), name, \
-            gl::TraceEvent::noEventId, TRACE_EVENT_FLAG_NONE, ##__VA_ARGS__);          \
-        INTERNALTRACEEVENTUID(profileScope)                                            \
-            .initialize(platform, INTERNALTRACEEVENTUID(catstatic), name);             \
-    }
+#define INTERNAL_TRACE_EVENT_ADD_SCOPED(platform, category, name, ...)                     \
+    INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO(platform, category);                            \
+    gl::TraceEvent::TraceEndOnScopeClose INTERNALTRACEEVENTUID(profileScope);              \
+    do                                                                                     \
+    {                                                                                      \
+        if (*INTERNALTRACEEVENTUID(catstatic))                                             \
+        {                                                                                  \
+            gl::TraceEvent::addTraceEvent(                                                 \
+                platform, TRACE_EVENT_PHASE_BEGIN, INTERNALTRACEEVENTUID(catstatic), name, \
+                gl::TraceEvent::noEventId, TRACE_EVENT_FLAG_NONE, ##__VA_ARGS__);          \
+            INTERNALTRACEEVENTUID(profileScope)                                            \
+                .initialize(platform, INTERNALTRACEEVENTUID(catstatic), name);             \
+        }                                                                                  \
+    } while (0)
 
 // Implementation detail: internal macro to create static category and add
 // event if the category is enabled.

util/windows/third_party/StackWalker/src/StackWalker.h

@@ -247,7 +247,7 @@ protected:
     memset(&c, 0, sizeof(CONTEXT));                               \
     c.ContextFlags = contextFlags;                                \
     RtlCaptureContext(&c);                                        \
-  } while (0);
+  } while (0)
 #endif
 
 #endif //defined(_MSC_VER)