Skip to content

A
angle
Commit 44df3fa9 by Ian Elliott Committed by Commit Bot
Options

Vulkan: Fix whitebox test to end render pass

Since the RAII-based GLRenderbuffer goes away at the end of the test function, we should end the render pass before ending the test. Bug: chromium:1122621 Change-Id: I5aaf2a0b4fd63a38fc5018830ee4e9d7d93f0c81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380248Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Reviewed-by: 's avatarIan Elliott <ianelliott@google.com> Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
parent 15438d3f
Showing with 5 additions and 0 deletions
src/tests/gl_tests/VulkanPerformanceCounterTest.cpp
...@@ -467,6 +467,11 @@ TEST_P(VulkanPerformanceCounterTest, InvalidatingAndUsingDepthDoesNotBreakRender ...@@ -467,6 +467,11 @@ TEST_P(VulkanPerformanceCounterTest, InvalidatingAndUsingDepthDoesNotBreakRender
uint32_t actualRenderPassCount = counters.renderPasses; uint32_t actualRenderPassCount = counters.renderPasses;
EXPECT_EQ(expectedRenderPassCount, actualRenderPassCount); EXPECT_EQ(expectedRenderPassCount, actualRenderPassCount);
// Make sure the render pass is ended by reading back a pixel. Otherwise, the render pass will
// end when the test infrastructure calls eglSwapBuffers(), after the RAII-based GLRenderbuffer
// has been deleted.
EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::red);
} }
// Tests that even if the app clears depth, it should be invalidated if there is no read. // Tests that even if the app clears depth, it should be invalidated if there is no read.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment