Commit 4671fee9 by Geoff Lang Committed by Commit Bot

Don't expose CHROMIUM_color_buffer_float_rgb[a] in ES3.0+

These extensions are superseded by EXT_color_buffer_float and not needed to support WebGL2. Allowing them to expose rendering to RGB[A]32F when EXT_color_buffer_float is not supported causes dEQP failures. BUG=angleproject:3939 Change-Id: Ib50a061526f29fc0628e732123c04a22800345dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1832525Reviewed-by: 's avatarTim Van Patten <timvp@google.com> Reviewed-by: 's avatarAlexis Hétu <sugoi@chromium.org> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
parent f03259ad
......@@ -3313,6 +3313,11 @@ Extensions Context::generateSupportedExtensions() const
{
supportedExtensions.colorBufferHalfFloat = false;
}
// Disable support for CHROMIUM_color_buffer_float_rgb[a] in ES 3.0+, these extensions are
// non-conformant in ES 3.0 and superseded by EXT_color_buffer_float.
supportedExtensions.colorBufferFloatRGB = false;
supportedExtensions.colorBufferFloatRGBA = false;
}
// Some extensions are always available because they are implemented in the GL layer.
......
......@@ -536,8 +536,6 @@
3676 VULKAN : dEQP-GLES3.functional.state_query.integers.max_fragment_input_components_get* = FAIL
// Formats:
3677 ANDROID VULKAN : dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgba32f = FAIL
3677 ANDROID VULKAN : dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.rgba32f = FAIL
3677 VULKAN : dEQP-GLES3.functional.fragment_out.basic.int.* = FAIL
3677 VULKAN : dEQP-GLES3.functional.fragment_out.basic.uint.* = FAIL
3677 VULKAN : dEQP-GLES3.functional.fragment_out.array.int* = FAIL
......
......@@ -3072,6 +3072,8 @@ void main()
// pipeline input. It works well. See http://anglebug.com/3658
TEST_P(ComputeShaderTest, DrawTexture1DispatchTexture2)
{
ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_color_buffer_float"));
const char kCSSource[] = R"(#version 310 es
layout(local_size_x=1, local_size_y=1, local_size_z=1) in;
precision highp sampler2D;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment