Skip to content

A
angle
Commit 494afea9 by Jonah Ryan-Davis Committed by Commit Bot
Options

Fix ShCompileTest.DecimalSepLocale failure.

The test had an additional check to make sure we have coverage on every platform, but this is unnecessary and requires too much overhead to maintain a list of good locales for all platforms. Bug: 941249 Change-Id: I3e6da2ad61453fc385edf5f18101c8cb13ae0503 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1520989 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 13a8c4d8
Showing with 0 additions and 8 deletions
src/tests/compiler_tests/ShCompile_test.cpp
...@@ -176,11 +176,4 @@ TEST_F(ShCompileTest, DecimalSepLocale) ...@@ -176,11 +176,4 @@ TEST_F(ShCompileTest, DecimalSepLocale)
testedLocales++; testedLocales++;
} }
} }
// Ignore for Android which doesn't use these locales
#if !defined(ANGLE_PLATFORM_ANDROID)
// This test must run on at least one different locale to pass
EXPECT_NE(testedLocales, 0)
<< "Missing locales to test on this platform. Add them to availableLocales[]";
#endif
} }
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment