Capture/Replay: Add const to string pointer

Traces that have shader compiles in the middle of the run are reusing the string pointers on each go through. On some (multiple) platforms, the string pointer is no good on the second run through. This may only happen for large strings. Adding a const qualifier on the pointer itself, not just the string, avoids the issue. This has the effect of changing strings from this: const char *glShaderSource_string_0[] = { const char *glShaderSource_string_1[] = { to this: const char* const glShaderSource_string_0[] = { const char* const glShaderSource_string_1[] = { Test: Pokemon Go MEC Bug: b/188091629 Bug: angleproject:5968 Change-Id: Id6a05c955adb3e1c43d2723450be6b5278d99fba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2895328 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Capture/Replay: Add const to string pointer
4b071880 · Cody Northrop · Commit Bot · 83d22b66 · 4b071880
Commit 4b071880 authored May 13, 2021 by Cody Northrop Committed by Commit Bot May 18, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

FrameCapture.cpp src/libANGLE/capture/FrameCapture.cpp +1 -1

No files found.
--- a/src/libANGLE/capture/FrameCapture.cpp
+++ b/src/libANGLE/capture/FrameCapture.cpp
@@ -398,7 +398,7 @@ void WriteStringPointerParamReplay(DataTracker *dataTracker,
        counter = dataTracker->getCounters().getAndIncrement(call.entryPoint, param.name);
        dataTracker->getStringCounters().setStringCounter(strings, counter);

-        header << "const char *";
+        header << "const char* const ";
        WriteParamStaticVarName(call, param, counter, header);
        header << "[] = { \n";