Skip to content

A
angle
Commit 4c5630d0 by Tim Van Patten Committed by Commit Bot
Options

Disable libcxx_abi_unstable in roll_aosp.sh

The definition _LIBCPP_ABI_UNSTABLE breaks std::string in Android AOSP builds, starting with GetHelperExecutableDir(), but others fail later if that's worked around. Instead, we'll disable that flag with a GN arg for AOSP rolls. Bug: angleproject:5263 Test: Build on AOSP and launch Cuttlefish Change-Id: Ia4b293a5ce0b09206f4ed87a5a442e544e2021c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508529Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
parent a5c9e672
Showing with 3 additions and 0 deletions
scripts/roll_aosp.sh
...@@ -80,6 +80,9 @@ for abi in ${abis[@]}; do ...@@ -80,6 +80,9 @@ for abi in ${abis[@]}; do
# Disable histogram/protobuf support # Disable histogram/protobuf support
"angle_has_histograms = false" "angle_has_histograms = false"
# Disable _LIBCPP_ABI_UNSTABLE, since it breaks std::string
"libcxx_abi_unstable = false"
) )
gn gen ${GN_OUTPUT_DIRECTORY} --args="${gn_args[*]}" gn gen ${GN_OUTPUT_DIRECTORY} --args="${gn_args[*]}"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment