Be sure to clear all program state at unlink

At Program::unlink we clear out the program's state but forgot mBufferVariables. That was causing us to hit an assert when trying to load a shader from cache. Only see the issue on Android as that's the only platform where shader caching is supported. Test: KHR-GLES31.core.explicit_uniform_location.uniform-loc Bug: angleproject:4132 Change-Id: Iae9c26a3e3b2d11983cc7d90bcd54a10c0fa9934 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107235Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

Be sure to clear all program state at unlink
4df67871 · Courtney Goeltzenleuchter · Commit Bot · 23d63fc3 · 4df67871
Commit 4df67871 authored Mar 17, 2020 by Courtney Goeltzenleuchter Committed by Commit Bot Mar 18, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

Program.cpp src/libANGLE/Program.cpp +1 -0

No files found.
--- a/src/libANGLE/Program.cpp
+++ b/src/libANGLE/Program.cpp
@@ -1886,6 +1886,7 @@ void Program::unlink()
    mState.mUniforms.clear();
    mState.mUniformLocations.clear();
    mState.mUniformBlocks.clear();
+    mState.mBufferVariables.clear();
    mState.mShaderStorageBlocks.clear();
    mState.mActiveUniformBlockBindings.reset();
    mState.mAtomicCounterBuffers.clear();