Skip to content

A
angle
Commit 4ecbe858 by Scott Graham Committed by Jamie Madill
Options

Avoid double copy of d3dcompiler_47.dll

ninja expects the output of an action to update the timestamp, however a plain copy does not do this. So on a second run, ninja sees the timestamp of the copy .bat is newer than the dll (original publish date) so it re-copies. To avoid this, `touch` the dll on copy. BUG=453037 Change-Id: Icb849d2b0faaceeccfc33e2eda509c835c9cdc93 Reviewed-on: https://chromium-review.googlesource.com/244040Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Tested-by: 's avatarScott Graham <scottmg@chromium.org> (cherry picked from commit b633dc61) Reviewed-on: https://chromium-review.googlesource.com/244051Tested-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 9e0478f6
Showing with 5 additions and 0 deletions
src/copy_compiler_dll.bat
...@@ -2,3 +2,8 @@ ...@@ -2,3 +2,8 @@
set _arch=%1 set _arch=%1
set _arch=%_arch:Win32=x86% set _arch=%_arch:Win32=x86%
copy %2"\Redist\D3D\"%_arch%"\d3dcompiler_47.dll" %3 > NUL copy %2"\Redist\D3D\"%_arch%"\d3dcompiler_47.dll" %3 > NUL
:: This is equivalent to `touch', see:
:: https://technet.microsoft.com/en-us/library/bb490886.aspx
:: This avoids rerunning because this batch file is also copied to the gen dir,
:: so it's timestamp would otherwise be newer than the dll.
copy /b %3\d3dcompiler_47.dll+,, %3\d3dcompiler_47.dll > NUL
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment