Commit 4f407ce2 by Jamie Madill Committed by Commit Bot

Fix Clang dEQP build on Win.

Rolls the build/ repos from Chromium to include the fixed config. Also includes incidental improvements to platform-specific hooks. Bug: chromium:727437 Change-Id: Ia42a30acac1e800e593e304bfc59d86eb0a1e57c Reviewed-on: https://chromium-review.googlesource.com/782340 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 378734c5
...@@ -6,13 +6,13 @@ vars = { ...@@ -6,13 +6,13 @@ vars = {
deps = { deps = {
'build': 'build':
Var('chromium_git') + '/chromium/src/build.git' + '@' + 'bd767a7bd2689943bca4b66009aad279b55487f8', Var('chromium_git') + '/chromium/src/build.git' + '@' + '8a1537f019e55807420ae76c62e4ce8f56fedca1',
'buildtools': 'buildtools':
Var('chromium_git') + '/chromium/buildtools.git' + '@' + '93a751e41bd93e373548759c6c5453bd95b6f35e', Var('chromium_git') + '/chromium/buildtools.git' + '@' + '461b345a815c1c745ac0534a6a4bd52d123abe68',
'testing': 'testing':
Var('chromium_git') + '/chromium/src/testing' + '@' + '8893f3930ce94c9e5350e0e87ddf159bf1d495b8', Var('chromium_git') + '/chromium/src/testing' + '@' + '6dfa36ab2e5143fa2f7353e3af5d2935af2e61f7',
# Cherry is a dEQP management GUI written in Go. We use it for viewing test results. # Cherry is a dEQP management GUI written in Go. We use it for viewing test results.
'third_party/cherry': 'third_party/cherry':
...@@ -54,6 +54,7 @@ hooks = [ ...@@ -54,6 +54,7 @@ hooks = [
{ {
'name': 'clang_format_win', 'name': 'clang_format_win',
'pattern': '.', 'pattern': '.',
'condition': 'host_os == "win"',
'action': [ 'download_from_google_storage', 'action': [ 'download_from_google_storage',
'--no_resume', '--no_resume',
'--platform=win32', '--platform=win32',
...@@ -65,6 +66,7 @@ hooks = [ ...@@ -65,6 +66,7 @@ hooks = [
{ {
'name': 'clang_format_mac', 'name': 'clang_format_mac',
'pattern': '.', 'pattern': '.',
'condition': 'host_os == "mac"',
'action': [ 'download_from_google_storage', 'action': [ 'download_from_google_storage',
'--no_resume', '--no_resume',
'--platform=darwin', '--platform=darwin',
...@@ -76,6 +78,7 @@ hooks = [ ...@@ -76,6 +78,7 @@ hooks = [
{ {
'name': 'clang_format_linux', 'name': 'clang_format_linux',
'pattern': '.', 'pattern': '.',
'condition': 'host_os == "linux"',
'action': [ 'download_from_google_storage', 'action': [ 'download_from_google_storage',
'--no_resume', '--no_resume',
'--platform=linux*', '--platform=linux*',
...@@ -88,6 +91,7 @@ hooks = [ ...@@ -88,6 +91,7 @@ hooks = [
{ {
'name': 'gn_win', 'name': 'gn_win',
'pattern': '.', 'pattern': '.',
'condition': 'host_os == "win"',
'action': [ 'download_from_google_storage', 'action': [ 'download_from_google_storage',
'--no_resume', '--no_resume',
'--platform=win32', '--platform=win32',
...@@ -99,6 +103,7 @@ hooks = [ ...@@ -99,6 +103,7 @@ hooks = [
{ {
'name': 'gn_mac', 'name': 'gn_mac',
'pattern': '.', 'pattern': '.',
'condition': 'host_os == "mac"',
'action': [ 'download_from_google_storage', 'action': [ 'download_from_google_storage',
'--no_resume', '--no_resume',
'--platform=darwin', '--platform=darwin',
...@@ -110,6 +115,7 @@ hooks = [ ...@@ -110,6 +115,7 @@ hooks = [
{ {
'name': 'gn_linux64', 'name': 'gn_linux64',
'pattern': '.', 'pattern': '.',
'condition': 'host_os == "linux"',
'action': [ 'download_from_google_storage', 'action': [ 'download_from_google_storage',
'--no_resume', '--no_resume',
'--platform=linux*', '--platform=linux*',
...@@ -119,7 +125,6 @@ hooks = [ ...@@ -119,7 +125,6 @@ hooks = [
], ],
}, },
{ {
# Pull clang if needed or requested via GYP_DEFINES.
# Note: On Win, this should run after win_toolchain, as it may use it. # Note: On Win, this should run after win_toolchain, as it may use it.
'name': 'clang', 'name': 'clang',
'pattern': '.', 'pattern': '.',
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
import("../../gni/angle.gni") import("../../gni/angle.gni")
import("//build/config/chromecast_build.gni") import("//build/config/chromecast_build.gni")
import("//build/config/angle_temp.gni")
import("//testing/test.gni") import("//testing/test.gni")
unittests_gypi = exec_script("//build/gypi_to_gn.py", unittests_gypi = exec_script("//build/gypi_to_gn.py",
...@@ -314,6 +313,7 @@ if (build_angle_deqp_tests) { ...@@ -314,6 +313,7 @@ if (build_angle_deqp_tests) {
deqp_undefine_configs = [ deqp_undefine_configs = [
"//build/config/compiler:chromium_code", "//build/config/compiler:chromium_code",
"//build/config/compiler:no_exceptions",
"//build/config/compiler:no_rtti", "//build/config/compiler:no_rtti",
] ]
...@@ -325,28 +325,15 @@ if (build_angle_deqp_tests) { ...@@ -325,28 +325,15 @@ if (build_angle_deqp_tests) {
] ]
} }
# TODO(jmadill): Fix this once upstream change is landed.
if (is_temp_angle) {
deqp_undefine_configs += [ "//build/config/compiler:no_exceptions" ]
} else {
if (is_linux || is_android || is_mac) {
deqp_undefine_configs += [ "//build/config/gcc:no_exceptions" ]
}
}
static_library("angle_deqp_decpp") { static_library("angle_deqp_decpp") {
configs -= deqp_undefine_configs configs -= deqp_undefine_configs
public_configs = [ public_configs = [
":angle_deqp_support", ":angle_deqp_support",
"//build/config/compiler:exceptions",
"//build/config/compiler:no_chromium_code", "//build/config/compiler:no_chromium_code",
angle_root + ":internal_config", angle_root + ":internal_config",
] ]
# TODO(jmadill): Fix this once upstream change is landed.
if (is_temp_angle) {
public_configs += [ "//build/config/compiler:exceptions" ]
}
sources = rebase_path(deqp_gypi.deqp_libtester_decpp_sources, ".", "../..") sources = rebase_path(deqp_gypi.deqp_libtester_decpp_sources, ".", "../..")
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment