Capture/Replay: Support glBufferStorageEXT

Add the entrypoint, and when a buffer is immutable, recreate it with glBufferStorageEXT. Test: MEC for Dota Underlords Bug: b/185192780 Bug: angleproject:5857 Change-Id: I29b934bdff4185d19594e49e9387dd79c6031aa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821945Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>

Capture/Replay: Support glBufferStorageEXT
4f723d2c · Cody Northrop · Commit Bot · 68f1203d · 4f723d2c · 4f723d2c
Commit 4f723d2c authored Apr 09, 2021 by Cody Northrop Committed by Commit Bot Apr 14, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 17 additions and 4 deletions

FrameCapture.cpp src/libANGLE/capture/FrameCapture.cpp +13 -3

capture_gles_ext_params.cpp src/libANGLE/capture/capture_gles_ext_params.cpp +4 -1

No files found.
--- a/src/libANGLE/capture/FrameCapture.cpp
+++ b/src/libANGLE/capture/FrameCapture.cpp
@@ -2191,9 +2191,19 @@ void CaptureMidExecutionSetup(const gl::Context *context,
            cap(CaptureBindBuffer(replayState, true, gl::BufferBinding::Array, id));
        }

-        cap(CaptureBufferData(replayState, true, gl::BufferBinding::Array,
-                              static_cast<GLsizeiptr>(buffer->getSize()), buffer->getMapPointer(),
-                              buffer->getUsage()));
+        if (buffer->isImmutable())
+        {
+            cap(CaptureBufferStorageEXT(replayState, true, gl::BufferBinding::Array,
+                                        static_cast<GLsizeiptr>(buffer->getSize()),
+                                        buffer->getMapPointer(),
+                                        buffer->getStorageExtUsageFlags()));
+        }
+        else
+        {
+            cap(CaptureBufferData(replayState, true, gl::BufferBinding::Array,
+                                  static_cast<GLsizeiptr>(buffer->getSize()),
+                                  buffer->getMapPointer(), buffer->getUsage()));
+        }

        if (bufferMapped)
        {

--- a/src/libANGLE/capture/capture_gles_ext_params.cpp
+++ b/src/libANGLE/capture/capture_gles_ext_params.cpp
@@ -3453,7 +3453,10 @@ void CaptureBufferStorageEXT_data(const State &glState,
                                  GLbitfield flags,
                                  angle::ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    if (data)
+    {
+        CaptureMemory(data, size, paramCapture);
+    }
 }

 // GL_EXT_separate_shader_objects