Check for GL_INVALID_INDEX instead of -1 for GetUniformIndices

While they have the same bit representation, the variable was unsigned so the comparison would always fail, which triggered a compilation warning. BUG= Change-Id: Idbbdb942b71d59f95e65c072dbbfdf31d14eda05 Reviewed-on: https://chromium-review.googlesource.com/303391Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Tryjob-Request: Corentin Wallez <cwallez@chromium.org> Tested-by: Corentin Wallez <cwallez@chromium.org>

Check for GL_INVALID_INDEX instead of -1 for GetUniformIndices
4fbec003 · Corentin Wallez · 4e7196a1 · 4fbec003
Commit 4fbec003 authored Oct 01, 2015 by Corentin Wallez
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

ProgramGL.cpp src/libANGLE/renderer/gl/ProgramGL.cpp +1 -1

No files found.
--- a/src/libANGLE/renderer/gl/ProgramGL.cpp
+++ b/src/libANGLE/renderer/gl/ProgramGL.cpp
@@ -356,7 +356,7 @@ void ProgramGL::gatherUniformBlockInfo(std::vector<gl::UniformBlock> *uniformBlo
        GLuint uniformIndex = 0;
        mFunctions->getUniformIndices(mProgramID, 1, &uniformName, &uniformIndex);
-        if (uniformIndex == -1)
+        if (uniformIndex == GL_INVALID_INDEX)
        {
            // Uniform member has been optimized out, remove it from the list
            // TODO: Clean this up by using a class to wrap around the uniforms so manual removal is